fixed Lodestone Bug with ImpactFrames#6
Open
VenWhoVian wants to merge 1 commit intoFINDERFEED:1.20.1from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
adaptive exposure was using glReadPixels to sample the main framebuffer on the cpu. that worked in vanilla-ish rendering, but lodestone changes the render pipeline enough that the readback was happening on the wrong buffer / wrong timing, so the exposure sample was just getting 0.0 or tripping GL_INVALID_OPERATION.
what I changed
removed the broken framebuffer readback path
basically just moved the screen reading code for the adaptive exposure to the GPU, and out of java