Update ice_area to handle NaNs#237
Merged
Merged
Conversation
koldunovn
reviewed
May 12, 2026
| def ice_area(data, mesh, hemisphere="N", attrs={}): | ||
| """ Compute sea ice volume. | ||
| def ice_area(data, mesh, hemisphere="N", threshhold=0.15, attrs={}): | ||
| """ Compute sea ice area. |
Member
There was a problem hiding this comment.
I am not sure it's a good idea to put threshhold=0.15 - this is something we use for ice_extent, but definition of the area it the total area covered by sea ice, and at leas in my mind this is what I would want to see by default. Adding threshold is totally fine, but I would put 0 as a default.
Member
|
I've enabled the CI, since this was an outside fork. Apart from @koldunovn comment about the threshold, this looks fine to me. |
Contributor
Author
|
Thanks, updated the branch. |
pgierz
approved these changes
May 12, 2026
Member
|
Alright, all tests pass, looks good. I am merging, nice work! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes copied from updates to ice_ext. Tested with AWI-ESM data which shows ~17 Mio km2 sea ice area for the Southern Ocean.