fesom2_test_refactoring: pin setuptools<80 to keep pkg_resources for mkfesom#4
Merged
Conversation
…resources setuptools 80 dropped the bundled pkg_resources module by default; mkfesom's mkrun.py still imports it, so building the image with current conda+pip yielded an mkrun that crashes immediately with 'ModuleNotFoundError: No module named pkg_resources' inside the recom and cavities CI workflows. Pin to <80 until mkfesom is migrated to importlib.resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enabling
docker-publish.ymlfrom its 60-day inactivity disable rebuilt all four images, and the newfesom2_test_refactoring-masterpicked up setuptools 80+ which dropped the bundledpkg_resourcesmodule. mkfesom'smkrun.pystill doesimport pkg_resources, so every workflow that uses this image (recom, cavities, channel, icebergs, openmp, neverworld2, …) now crashes immediately:Pin setuptools to
<80right before the mkfesompip install -e .sopkg_resourcesis still available. The proper long-term fix is to migrate mkfesom toimportlib.resources, but that's an mkfesom-side change.