Cleanup/lambda fhir processor#4
Open
lab596 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces extensive documentation, development utilities, and configuration files to the
fhir-processorLambda project. The main focus is on providing a comprehensive technical overview, supporting local development and testing, and ensuring correct dependency management and AWS permissions. No core processing code is changed, but these additions significantly improve maintainability, onboarding, and troubleshooting.Documentation and Developer Support:
README.mdexplaining architecture, differential update logic, FHIR resource mapping, data flow, environment variables, testing strategies, error handling, and future enhancements. This serves as a technical reference for developers and stakeholders.inspect_dump.py,inspect_counts.py,inspect_encrypted_dump.pyfor analyzing SQL dumps and encrypted files.inspect_keys.pyfor extracting key usage from the processing code.local_parse_test.pyfor locally testing the SQL parser. [1] [2] [3] [4] [5]Configuration and Dependency Management:
requirements.txtandrequirements-dev.txtspecifying all runtime and development dependencies, including FHIR libraries, database drivers, AWS SDK, and encryption utilities. [1] [2].gitignoreto exclude Python caches, test artifacts, and logs from version control.AWS Integration and Permissions:
invoke_event.json) and Lambda response/error files (invoke_result.json,response.json) to aid in local simulation and debugging. [1] [2] [3]s3-read-policy.json) granting the Lambda function necessary permissions to read from the S3 bucket.