Skip to content

Conversation

@MatiasArriola
Copy link

Required by: https://app.clickup.com/t/8699feudb

This PR backports email verification and email 2FA features from 2.42 to 2.41.3.1 via cherry-picking and manual conflict resolution.

It also includes support for multiple TwoFactorType values, which is essential for implementing additional 2FA methods like SMS.

Testing requires a modified version of the latest user-settings-app (100.7.4).

To enable, in dhis_2.conf use:

login.security.totp_2fa.enabled = on
login.security.email_2fa.enabled = on

Pending:

  • Review and fix failing automated tests

netroms and others added 17 commits June 24, 2025 14:54
* feat: email verification

(cherry picked from commit 2677448)
[SMS2FA]
This includes manual merge conflict resolution and fixes because incompatible changes. Most of them tagged with [SMS2FA]

(cherry picked from commit 80e3d05)
Manual resolutions tagged with [SMS2FA]

(cherry picked from commit 402e2b7)
manual resolutions for SystemSettingManager + fix from previous commit

(cherry picked from commit 015736f)
* fix: when you change your email and re-verify your email, 2FA needs to be disabled

(cherry picked from commit e0327d8)
* feat: expose allowed 2FA types in the configuration endpoint

(cherry picked from commit 7eb6381)
[SMS2FA] also added back ApplicationEventPublisher and HttpSessionEventPublisher

(cherry picked from commit 80e3d05)
dhis-test-web-api tests were failing.
This is not defined this way in upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants