Skip to content

ci: rehearse a release without publishing - #973

Merged
robinnsc merged 1 commit into
mainfrom
ci/release-dry-run
Nov 13, 2026
Merged

robinnsc merged 1 commit into
mainfrom
ci/release-dry-run

Conversation

@robinnsc

@robinnsc robinnsc commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What

A way to rehearse the release without publishing anything, for the 1.0 release and the ones after it.

dry_run input on release-image, release-dev-image and npm-publish. With it checked, the run ends after the gate and build jobs, which run as for a release. In the two image workflows: the tag gates (strict shape, exists on origin, on main, matches Cargo.toml), the licence-notice check, devtools/check-released-through, both architectures' builds on their native runners, their smoke tests, vulnerability scans and SBOMs. In npm-publish: the tag and migration gates and the five platform builds with their smoke tests and launcher suites. The publish/publish-candidate job carries if: ${{ !inputs.dry_run }}; propagate and attest have no if of their own and are skipped because the job they need is skipped. So no environment asks for approval and nothing reaches Docker Hub, GHCR, ECR Public, npm or Rekor. Dry runs have a concurrency group of their own (-dry), so a dry run cannot cancel a pending release. A dry-run-summary job writes the tag, commit and version to the step summary. Under dry_run the build matrices run with fail-fast: false, so a rehearsal reports every architecture and platform where a release stops at the first. Dispatching without the input is unchanged.

devtools/release-dry-run. The same gate and build steps on a developer's machine, for the host's architecture: the clean-tree, licence and check-released-through gates, then for each of the postgres, mongodb, cassandra and dev images the docker build with the release's build-args (VERSION from Cargo.toml, VCS_REF the commit, BUILD_DATE the commit's timestamp, --platform the host's), the architecture check, the scan and SBOM through the release's pinned trivy image with the release's flags and the release's SBOM validation, and the image's ci/smoke-test-*-container.sh. --tag vX.Y.Z adds the tag gates, read from the remote (ls-remote, FETCH_HEAD) so a local tag or branch cannot stand in; --crates adds release-crates.yml's publish plan and verify job (cargo package --workspace --locked, check-crate-packages, the SHA-256 record of each package); --images picks a subset or none; --keep and --reuse-images let a smoke test be re-run without a rebuild, and an image the run did not build is never removed. Images are tagged extenddb-dry-run/<image>:<commit>-<arch>, a name no release uses; logs, tarballs and SBOMs go under target/release-dry-run/. Every step runs in a subshell with errexit and the summary lists each outcome with its log; the exit code is 1 when anything failed, or --stop-on-fail stops at the first failure as the real gate does.

packaging/README.md: the release flow gains the rehearsal as its second step, and the later steps are renumbered.

Why

The release is five manual dispatches against one tag, and the Cassandra image has never been released (the extenddb/extenddb-cassandra repository on Docker Hub, registered on 4 November, has no tags; v0.1.14 shipped postgres, mongodb, dev and npm). Before 1.0 the team wants to run the release path across all four backends and see what fails, without consuming a version on npm or moving a Docker Hub tag. release-image is already candidate-first, but it still pushes, signs, mirrors and attests; release-dev-image publishes the version tag and moves latest; npm-publish consumes the version number. So a throwaway tag is not a rehearsal.

The gate and build jobs were already side-effect free; the input only has to stop the run there.

Closes: n/a

Testing done

devtools/release-dry-run --keep --crates (with PYTHON pointing at a 3.12) on main at 5804374, x86_64, 16 cores:

step outcome
gate: migrations frozen FAIL: RELEASED_THROUGH is 0 and the last migration is 10 (the release PR raises it; see below)
postgres: licence, build, arch, scan, SBOM (427 components, 333 crates), smoke PASS
mongodb: licence, build, arch, scan, SBOM (470, 376), smoke PASS
cassandra: licence, build, arch, scan, SBOM (93, 0: Dockerfile.cassandra does not use cargo auditable), smoke (178 s) PASS
dev: licence, build, arch, SBOM (344, 332), smoke PASS
dev: vulnerability scan FAIL: libssl3 3.0.20-1deb12u2, CVE-2026-84782 HIGH, fixed in 3.0.22-1deb12u2. Dockerfile.dev's runtime stage is gcr.io/distroless/cc-debian12:nonroot pinned by digest with no RUN step, so a rebuild keeps this libssl3; the pinned image and the current nonroot build both carry 3.0.20-1deb12u2 (Lee's check). The dev image passes its scan only once the pin moves to a distroless build with 3.0.22-1deb12u2, which is a 1.0 blocker to track
crates: publish plan, cargo package --workspace --locked (475 s), package rules PASS (the plan lists all 14 crates as new and stops before the first, as designed)

The two failures are the release's real state today, not the script's. bash -n and shellcheck -S warning are clean. The three workflows parse (yaml.safe_load), each has dry_run in its inputs, and in each the publish job carries if: ${{ !inputs.dry_run }} while propagate and attest keep their needs on it, so they skip with it. Lee dispatched the three workflows from this branch with dry_run against v0.1.14 (runs 43422561132, 43422561669, 43422518630): the gates, builds and summaries passed on release-image and npm-publish, release-dev-image's builds failed the scan on the libssl3 finding above, every publish-side job was skipped and no environment asked for approval. --tag v0.1.14 was run locally against a commit it does not name (below).

Review round (2026-11-12): two hostile reviews of the first push

Two independent reviews of eeabc50d, one on the workflows and release safety, one on the script's shell and its fidelity to the workflows. Neither found a way for dry_run to publish, sign, mirror or attest (job ifs, needs skipping, boolean input, environments on skipped jobs). What they found, all fixed in 5e8ebcb4:

Workflows:

  • The npm dry_run description and the README step promised scans and SBOMs that npm-publish has none of; each workflow's description now says what it runs.
  • The summary step interpolated the raw ${{ inputs.tag }} into run:, the only raw dispatch input to reach a shell in these files; it prints v${{ needs.gate.outputs.version }}, which the gate validated.
  • fail-fast: ${{ !inputs.dry_run }} on the image build matrices and the npm matrix call, so a rehearsal reports every leg.
  • The header said "every release workflow" (release-crates, promote-image and sign-image have no dry_run); the dev summary hard-coded the repo instead of env.IMAGE_REPO; the headers now say a dry run holds the workflow's concurrency group.

Script:

  • errexit was off inside every step (a function called under if), so a failed git fetch or trivy run was reported as a later symptom; each step now runs in ( set -e; ... ).
  • --stop-on-fail printed the summary before the failing log's tail; the tail comes first.
  • The local image was tagged with the published candidate's name (extenddb/extenddb-<image>:sha-<sha>-<arch>), so a pulled candidate could be retagged, rehearsed as a build and removed; the name is now extenddb-dry-run/<image>:<commit>-<arch>, and only images this run built are removed.
  • --reuse-images without --keep deleted the reused image; an unknown --images value aborted after the gates with no summary; a dirty tree was rehearsed as the commit (a clean-tree gate now fails it); --images "" passed with nothing run (none is explicit).
  • The SBOM check dropped the workflow's ImageID assertion and no-crates warning; it is the workflow's check, so the Cassandra image (plain cargo build) now reports the warning the release would.
  • --crates omitted --version, the SHA-256 record step and the toolchain note; the tag gate fetched into local refs (a differing local tag was reported as missing on origin) and read origin/main through the remote's refspec; no --platform on docker build; the work directory under $TMPDIR is not shared with the daemon on some hosts (now under target/); prerequisites missed the daemon, compose v2, cargo-about, timeout and $PYTHON; --tag as the last argument died with an unbound-variable message; the help range was a hard-coded line span.

Re-run of the rewritten script on 5e8ebcb4 with --reuse-images --keep --crates: the same outcomes as the table above, plus the clean-tree gate and the SHA-256 record passing, and the Cassandra SBOM step now printing the no-crates warning. --tag v0.1.14 against this commit fails with "tag v0.1.14 is b5bffa3 on origin; the checked-out commit is 5e8ebcb", the ls-remote path. --stop-on-fail on a dirty tree prints the git status lines and then the summary.

Review round two (2026-11-13): Lee's review of 5e8ebcb4

Required, all fixed in this head:

  • run ignored errexit (Blocking): the subshell was the condition of an if, where bash ignores set -e inside it too; a step whose first command failed ran on and was recorded PASS (reproduced on bash 4.2.46 with a false; echo step). The subshell now runs outside any condition, set +e; ( set -e; "$@" ); status=$?; set -e, and the probe step is recorded FAIL with its later command not run.
  • --crates used the host's toolchain: release-crates.yml runs every cargo on RUST_TOOLCHAIN (1.97.0). The script reads that pin from the workflow, exports RUSTUP_TOOLCHAIN, installs the toolchain if absent, fails the new crates: toolchain step when rustc --version is not the pin, and writes the pin into the record's TOOLCHAIN file. The SHA-256 of every package differs between 1.97.0 and this host's 1.98.0 cargo package, so the pin matters for the record too.
  • README step 2: says to run devtools/release-dry-run on the release commit before the tag is pushed (a failure there costs a commit, not a version), and that protect-release-tags blocks any update of a v* tag, so a rehearsal failure that needs a code change after the push takes the next patch version. The "a maintainer dispatches the workflows" sentence moved from step 1 to step 3.
  • Description: the five wrong statements are corrected above (the dev scan row, What's account of what npm-publish runs and of why propagate and attest skip, Why's Docker Hub repository, Testing done's "not run").

Minor, also fixed:

  • Dry runs have their own concurrency group, <group>-dry as project-status-sweep.yml does, so a dry run cannot cancel a pending release; the header sentences about holding the group are gone.
  • docker build --no-cache, as the release's cache-less build, so a rerun installs the base image's current package updates where the Dockerfile upgrades them; the header says so and points at --reuse-images for a cheap rerun. (A --no-cache dev build took 548 s here where the cached replay took 2 s.)
  • A run without --reuse-images no longer removes a kept image: the build moves the tag, the run records <new id>|<tag>|<previous id> for the images it built, removes those by id at the end and gives the kept image its tag back. Lee's reproduction (--images dev --skip-scan after a --keep run) now leaves the kept image with its tag.
  • The SBOM check is one script, devtools/check-image-sbom SBOM DOCKERFILE, that both image workflows' SBOM steps and release-dry-run call (annotations under GITHUB_ACTIONS, plain text otherwise; check_image_sbom_test.py, 10 cells, runs in scripts-test.yml). The build jobs check out the tagged commit, so a tag from before this PR has no script; the step says so and fails. The trivy pin is read from release-image.yml by the script, leaving the two workflow copies.

Not in this PR, from the review: #458 also edits npm-publish.yml and would merge with two if: keys on publish; Lee will fix that in #458 if this merges first. ECR Public has no extenddb-cassandra repository, so the first Cassandra release would fail in propagate after the candidate is pushed and signed; a dry run stops before that job and cannot show it. Both belong on the 1.0 checklist.

Checklist

  • I have read CONTRIBUTING.md
  • All tests pass (cargo test --workspace): no Rust changed
  • Code is formatted (cargo fmt --check): no Rust changed
  • Clippy is clean: no Rust changed
  • I have added or updated tests for new functionality: the script is exercised by running it; scripts-test.yml runs only the Python devtools' unit tests
  • I have updated documentation if behavior changed
  • Breaking changes are noted below (if any): none

ADR / RFC: n/a


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.

@robinnsc robinnsc added v1 Needed for the 1.0 release release-blocker Must ship for its milestone's release labels Nov 12, 2026

@LeeroyHannigan LeeroyHannigan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran devtools/release-dry-run --keep --crates on the head on an amd64 host, and then its edge cases. I also dispatched the three workflows from this branch with dry_run checked. They ran against v0.1.14, which is on main at version 0.1.14:

  • release-image, extenddb-postgres (run 43422561132): the gate, both builds and the summary passed. The arm64 build first failed to pull the trivy image (ECR Public answered toomanyrequests: Rate exceeded) and passed when I re-ran that job. publish-candidate, propagate and attest were skipped.
  • npm-publish (run 43422561669): the gate, the five platform builds and the summary passed, and publish was skipped.
  • release-dev-image (run 43422518630): both builds failed the scan on libssl3 CVE-2026-84782, the finding of your local run. publish, propagate and attest were skipped.

None of the three runs asked for an environment approval.

What matched the description:

  • With dry_run checked, no job that runs has an environment, an id-token, packages, attestations or contents: write permission, or a registry login. Without the input, each workflow runs the same jobs as on main.
  • My run of the script gave your table: the same two failures, and the same SBOM counts for the four images. It took 46 minutes on a loaded host.
  • The smoke tests published ports on 127.0.0.1 only.
  • The publish plan stops before the first crate, and nothing in the script pushes, uploads, tags or logs in.
  • --images none, an unknown --images value, --tag with no value, --tag v0.1.14, --stop-on-fail on a dirty tree and --reuse-images --keep behaved as the description says.
  • shellcheck at warning and style level, and actionlint, report nothing in the changed files.

Four items are required. Three are inline. The fourth is the description, where these statements are wrong:

  • The dev scan row says of the libssl3 finding: "a rebuild on release day picks the fix up". Dockerfile.dev builds its runtime stage on gcr.io/distroless/cc-debian12:nonroot pinned by digest, with no RUN step, so a rebuild keeps the same libssl3. The pinned image and the current nonroot build both carry 3.0.20-1deb12u2. The dev image passes its scan only after the pin moves to a distroless build with 3.0.22-1deb12u2.
  • What says that the licence check, both architectures, the scans and the SBOMs run in the three workflows. npm-publish runs the tag and migration gates and the five platform builds, with their smoke tests and launcher suites.
  • What says that propagate and attest are skipped by an if on the input. They have no if. They are skipped because the job they need is skipped.
  • Why says that there is no extenddb/extenddb-cassandra on Docker Hub. The repository exists, registered on 4 November, and has no tags.
  • Testing done says that the workflows and --tag were not run. The Review round section reports a --tag run, and the three runs above now exist.

Four inline items are Minor.

Outside this PR:

  • #458 (mine) also changes npm-publish.yml. git merges the two with two if: keys on publish and no conflict marker, and actionlint rejects the result. #458's promote job also has no dry_run term. If this PR merges first, I'll fix both in #458.
  • ECR Public has no extenddb-cassandra repository: an anonymous read answers NAME_UNKNOWN. Nothing in the release workflows creates it, so the first Cassandra release would fail in propagate, after the candidate is pushed and signed. A dry run stops before that job, so it cannot show this.

Once the required items are fixed, I'll approve. The Minor items can go in the same revision.

Comment thread devtools/release-dry-run Outdated
run() {
local name="$1" log="$WORK/$2"; shift 2; [[ "$1" == "--" ]] && shift
local start=$SECONDS
if ( set -e; "$@" ) >"$log" 2>&1; then

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subshell is the condition of an if, where bash ignores -e. The bash manual, under set -e, says that this also applies to a compound command that sets -e in that context. I copied this function into a test script unchanged. A step whose first command is false runs its later commands and is recorded as PASS, on bash 4.2.46 and 5.2.21. In tag_gates, a failed git fetch --no-tags origin main at line 206 leaves merge-base to read the previous FETCH_HEAD. The gate can then report "on main" for a commit that is not on main. Please run the subshell outside the condition and branch on its status. This form fails the step on both bash versions: set +e; ( set -e; "$@" ) >"$log" 2>&1; status=$?; set -e. ( set -e; "$@" ) || status=$? does not work either, because an || list is also a context where -e is ignored.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I reproduced it on bash 4.2.46 with a false; echo step: the old form recorded PASS and ran the echo. run now uses the form you give: set +e; ( set -e; "$@" ) >"$log" 2>&1; status=$?; set -e, and branches on status. The same probe step is recorded FAIL with the later command not run, and the comment on run says why the subshell must not be an if condition or an || list.

Comment thread devtools/release-dry-run
# --- crates.io: release-crates.yml's plan (a gate step) and verify job ----------
if [[ $CRATES == 1 ]]; then
run "crates: gate: publish plan" crates-plan.log -- "$PYTHON" devtools/publish-crates --dry-run --version "$VERSION"
run "crates: cargo package --workspace" crates-package.log -- cargo package --workspace --locked

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo package runs on the cargo on PATH. On my host that was rustc 1.99.0, and the TOOLCHAIN file of the SHA-256 record says so. In release-crates.yml, every job that runs cargo, verify and publish included, uses RUST_TOOLCHAIN: "1.97.0". A crate that builds on 1.99 and not on 1.97.0 passes the rehearsal and fails the release. Please read the pin from release-crates.yml and set RUSTUP_TOOLCHAIN to it for the crates steps. The script can then fail when rustc --version does not match the pin. Line 331 can also write the pin into TOOLCHAIN, as the workflow does.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. The script reads RUST_TOOLCHAIN from release-crates.yml (one copy), exports RUSTUP_TOOLCHAIN for the crates steps, installs the toolchain with rustup toolchain install --profile minimal if absent, and a new crates: toolchain 1.97.0 step fails unless rustc --version starts with rustc 1.97.0 . The TOOLCHAIN file of the record is the pin, as the workflow writes it. Worth noting: the SHA-256 of every package differs between the 1.97.0 run and this host's earlier 1.98.0 run, so the pin matters for the record, not only for the build.

Comment thread packaging/README.md Outdated
migration"). The gate jobs of the release workflows run
`devtools/check-released-through` on the tag and refuse it otherwise.
2. Dispatch the `npm-publish` workflow from `main` with the tag as input.
2. Rehearse first: dispatch `npm-publish`, `release-dev-image` and

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rehearsal on CI needs the release tag on origin, and the protect-release-tags ruleset blocks any update or deletion of a v* tag. A rehearsal failure that needs a code change therefore takes the next patch version. Please say so in this step, and say to run devtools/release-dry-run on the release commit before the tag is pushed. Step 1 also still says "A maintainer dispatches the container and npm publish workflows independently against it", before this step's rehearsal. That sentence belongs in step 3.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Step 2 now opens with running devtools/release-dry-run on the release commit before the tag is pushed (a failure there costs a commit, not a version), then the tag push and the three dry_run dispatches, and closes with the protect-release-tags rule: a rehearsal failure that needs a code change after the push takes the next patch version. The "A maintainer dispatches the container and npm publish workflows independently against it. The crates.io workflow runs last, after promote-image." sentences moved from step 1 to the head of step 3.

Comment thread .github/workflows/release-image.yml Outdated
# both builds, smoke tests, scans and SBOMs run as for a release, and nothing
# is published, signed or attested. A release rehearsal dispatches the three
# publish workflows (this one per image, release-dev-image, npm-publish) this
# way against the tag first, then again for real. A dry run holds the

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. A dry run and a release of one image share this concurrency group. GitHub keeps one pending run per group, and a newly queued run cancels the pending one. So if a dry run is running and a release is pending, a second dry run cancels the pending release. The project-status-sweep.yml workflow gives its dry runs their own group with ${{ inputs.dry_run && '-dry' || '' }}. With the same suffix here and in release-dev-image.yml and npm-publish.yml, a dry run cannot cancel a pending release. These header sentences could then go.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The three groups take ${{ inputs.dry_run && '-dry' || '' }}, as project-status-sweep.yml does, and the header sentences about a dry run holding the group are replaced by one saying dry runs have a group of their own.

Comment thread devtools/release-dry-run Outdated
files_exist() { [[ -f "$1" && -f "$2" ]] || { echo "missing $1 or $2"; return 1; }; }

build_image() { # dockerfile image
docker build -f "$1" --platform "linux/$ARCH" \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. The build uses the host's layer cache. A second run on the same commit replayed every layer from the cache, including the runtime stage's apt-get upgrade. The rebuild took 2 s and gave the same image ID as the run 47 minutes earlier. A rerun days later does not see a Debian security update that the release's build, which has no cache, would install. --no-cache here would remove the difference. Otherwise, the header can say that a rerun reuses the cached layers.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: docker build --no-cache, as the release's build has no cache. The header says so and points at --reuse-images for a cheap rerun. The cost is what you'd expect: the dev build took 548 s here where the cached replay took 2 s.

Comment thread devtools/release-dry-run Outdated
if [[ $REUSE == 1 ]] && docker image inspect "$img" >/dev/null 2>&1; then
record "$image: build ($ARCH)" SKIP 0 "--reuse-images: $img exists and is kept"
else
docker image rm -f "$img" >/dev/null 2>&1 || true

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. Without --reuse-images, this line removes an image a --keep run left. I ran --images postgres --skip-scan after a --keep run. It removed the kept postgres image, rebuilt it from cache and removed it at the end. The header at line 44 and the description say that an image this run did not build is never removed. Comparing the image ID before and after the build would make that true. Or the header can say that a run without --reuse-images replaces the kept image.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed so the header's statement is true. The pre-build docker image rm is gone. The run records the tag's image id before the build and after it; when they differ it keeps <new id>|<tag>|<previous id>, and the cleanup removes the images it built by id and then retags the previous id, so a kept image gets its tag back. Your reproduction (--images dev --skip-scan after a --keep run) now ends with the kept image under its tag; a run that finds no kept image removes only what it built, as before.

Comment thread devtools/release-dry-run
sbom_image() { # image tarball dockerfile sbom
save_image "$1" "$2"
docker run --rm -v "$2:/image.tar.gz:ro" "$TRIVY_IMAGE" image --input /image.tar.gz \
--format cyclonedx --no-progress --skip-version-check > "$4"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. This SBOM check is now in three places, here and in release-image.yml and release-dev-image.yml, and the trivy image digest is in five. A devtools/check-image-sbom that both workflows and this script call would leave one copy of the check.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. devtools/check-image-sbom SBOM.cdx.json DOCKERFILE is the one copy: both image workflows' SBOM steps call it instead of their inline Python, and so does the script. It prints ::error::/::warning:: annotations when GITHUB_ACTIONS is set and plain text otherwise; devtools/check_image_sbom_test.py (10 cells) runs it through scripts-test.yml. One consequence to know about: the build jobs check out the tagged commit, so a tag from before this PR has no script; the step checks for it and fails with a message saying to use a later tag, as the licence gate does for a missing Dockerfile. The trivy digest is now read from release-image.yml by the script, so it lives in the two workflows only.

The three publish workflows (release-image, release-dev-image, npm-publish)
gain a `dry_run` input. With it the run ends after the gate and build jobs:
the tag gates, the licence and migration-freeze checks, both architectures'
builds, smoke tests, vulnerability scans and SBOMs run as for a release, and
the publish, propagate and attest jobs are skipped, so their environments ask
no approval and nothing reaches a registry. A `dry-run-summary` job writes
what ran to the step summary.

`devtools/release-dry-run` runs the same gate and build steps on a
developer's machine for the host's architecture: the licence check and
`check-released-through`, then for each of the postgres, mongodb, cassandra
and dev images the build with the release's build-args, the architecture
check, the scan and SBOM through the release's pinned trivy image, and the
image's `ci/smoke-test-*-container.sh`. `--tag` adds the tag gates;
`--crates` adds release-crates.yml's verify job (the publish plan,
`cargo package --workspace --locked`, `check-crate-packages`). Every step is
attempted and the summary lists each outcome.

packaging/README.md's release flow gains the rehearsal as its second step.

Run on main at 5804374 for all four images: every build, scan, SBOM and
smoke test passed except the dev image's scan (libssl3 CVE-2026-84782, fixed
in 3.0.22-1~deb12u2, which a rebuild picks up) and the migration-freeze gate
(RELEASED_THROUGH is 0, the last migration 10), which the release PR raises.

Signed-off-by: Scott Robinson <robinnsc@amazon.com>
@robinnsc

Copy link
Copy Markdown
Collaborator Author

All four required items are fixed in 7552aaf0, the Minors with them, and the description's five statements are corrected: the dev scan row now says the runtime stage is distroless pinned by digest with no RUN step, so a rebuild keeps the libssl3 and the pin has to move to a build with 3.0.22-1~deb12u2 (tracked as a 1.0 blocker); What says what npm-publish runs and that propagate and attest skip because the job they need is skipped; Why says the Docker Hub repository exists with no tags; Testing done cites your three runs and the --tag run. The description also carries a "Review round two" section with the list.

Thanks for the two notes outside the PR. I've put both on the description as 1.0 checklist items: the #458 merge (two if: keys on publish) and the missing ECR Public extenddb-cassandra repository, which a dry run cannot reach since it stops before propagate.

Checks on this head: the shared SBOM check against the kept SBOMs (postgres 427/333, cassandra 93/0 with the warning), its 10 unit cells, bash -n, shellcheck -S warning, the three workflows parsing, the errexit probe, your kept-image reproduction, and --images none --crates on 1.97.0 (toolchain, plan, cargo package 511 s, rules and record all PASS).

@robinnsc
robinnsc dismissed LeeroyHannigan’s stale review November 13, 2026 22:14

Addressed comments

@robinnsc
robinnsc added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit d1f6677 Nov 13, 2026
62 checks passed
@robinnsc
robinnsc deleted the ci/release-dry-run branch November 13, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-blocker Must ship for its milestone's release v1 Needed for the 1.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants