Repository navigation
fix(streams): disabling a stream closes its shards; enabling makes a new one #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LeeroyHannigan
wants to merge
15
commits into
main
Choose a base branch
from
fix/482-stream-disable-closes-shards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,435
−1,862
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4ca0632
fix(streams): disabling a stream closes its shards; enabling creates …
LeeroyHannigan 6f9089f
fix(streams): GetRecords resolves a shard against the stream its id n…
LeeroyHannigan 690073d
test(streams): read re-enabled and relabelled streams by the shard id…
LeeroyHannigan ff46ea4
fix(engine): a StreamSpecification that is not an object stays a Seri…
LeeroyHannigan cea6f30
fix(streams): apply the ShardId maximum only when the shard is not found
LeeroyHannigan 7723249
fix(streams): a refused disable of a disabled stream closes the shard…
LeeroyHannigan bdba4fb
perf(postgres): lock only the record's shard row on a streamed write
LeeroyHannigan b3eae75
perf(mongodb): index stream_shards by table_id and shard_id
LeeroyHannigan 7823db8
fix(cassandra): start a new stream above the closed streams' ending n…
LeeroyHannigan c818c0a
docs(streams): upgrade order for stream changes, and what a disable s…
LeeroyHannigan 5433ed3
refactor(streams): move the engine stream tests and the ListStreams b…
LeeroyHannigan 53e42fb
test(postgres): pin stream labels through the shard ids the stream ca…
LeeroyHannigan a8d80ef
fix(streams): an enable closes the open shards of every earlier stream
LeeroyHannigan 25f9593
refactor(postgres): split the stream disable storage tests into two f…
LeeroyHannigan a42aeb7
refactor(streams): move the labelled shard checks and the Cassandra s…
LeeroyHannigan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for a
StreamSpecificationthat isn't an object ("x",1,[]),spec.get("StreamEnabled")is None, so this answers the null-member ValidationException where main answered SerializationException. SDKs can't send those shapes, so it hardly matters, butif spec.is_object()would keep it. Also, the new doc block sits insidedeserialize_error's doc comment, so the "Enum validation errors ... SerializationException" lines now document this function, anddeserialize_errorhas none.