Repository navigation
Revert "Remove the .repository-content fallback from the K2 dashboard" - #392
Merged
Merged
Conversation
This reverts commit bf8424c. GitHub still serves the classic repository page, with .repository-content and no #ui-service-main-content, to some browsers. Firefox gets it, so the dashboard fails to render there.
|
GitHub is also serving the old repo pages on Chrome for me, so K2 is broken on Chrome too. |
Contributor
Author
|
Thanks @c3024 - looks like GitHub is doing a staged roll-out of their new UI. We're not in the blessed group (yet) 😄 |
NicolasBonet
approved these changes
Oct 2, 2026
Contributor
|
Looks good, sorry guys, I wasn't expecting this to be a phased rollout 🤦♂️ |
Contributor
|
🚀 Released in version 1.5.69 🚀 |
|
@NicolasBonet looks like this was merged without a test passing. These checks had not passed on c9328f1 when it was merged:
Please add a note explaining why this was done and remove the |
Contributor
|
The checks were passing: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is a revert of bf8424c from #391.
The K2 dashboard does not render in Firefox. The console shows
K2: could not find #ui-service-main-content to render the dashboard into.Cause
GitHub still serves the classic repository page to some browsers. On Firefox,
document.getElementById('ui-service-main-content')returnsnullanddocument.querySelector('.repository-content')returns the container. bf8424c removed the.repository-contentfallback, so the dashboard has no container on the classic page.This revert restores the fallback and the classic-only step that clears
.repository-contentbefore the dashboard renders. The React page still uses#ui-service-main-content.Fixed Issues
None
Tests
[!!document.getElementById('ui-service-main-content'), !!document.querySelector('.repository-content')]and saw[false, true].git diff a3aab57e -- src/js/module/dashboard/index.jsand saw no output. The file matches its state before bf8424c.Not tested:
npm run lint,npm run build, and the dashboard on either browser after the revert.