[CP staging] Revert "fix: allow split percentage input selection on web (follow-up)" #79926
Conversation
melvin-bot
bot
requested review from
joekaufmanexpensify
and removed request for
a team
pecanoro
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c18280523a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| e.preventDefault(); | ||
| }} | ||
| onMouseDown={(e) => e.preventDefault()} |
There was a problem hiding this comment.
Calling preventDefault() on every mouseDown at the list-item level cancels the browser’s default focus behavior for any descendant input. Inputs used inside list rows (e.g., the split amount/percentage fields) do not stop propagation, so their mousedown bubbles here and the click can no longer focus or select the text, which makes editing those fields on web unreliable. This check was previously scoped to non-input targets, so removing that guard reintroduces the regression.
Useful? React with 👍 / 👎.
Beamanator
deleted the
revert-79290-ikevin127-allowPercentageSelection
branch
|
@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
straight revert, no emergency here |
…PercentageSelection [CP staging] Revert "fix: allow split percentage input selection on web (follow-up)" (cherry picked from commit e6cc786) (cherry-picked to staging by Beamanator)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.3.4-6 🚀
|
|
requested retest 👍 |
|
I don't think this reverted that issue. |
Reverts #79290
Fixes issues
$ #79849