-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Create GPS expenses using captured data #79914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create GPS expenses using captured data #79914
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
|
Explanation of Change
Adding ability to create GPS expenses using recorded trip data
Fixed Issues
$ #77215
PROPOSAL: N/A
Tests
Creating expense from FAB (create at least two works workspaces first with
More features>Distance ratesenabled and with rates with different currencies and distance units):NextCreateSelfDM:
NextCreateExisting report:
+at the bottom >Track distance>GPStab)Split expense:
More>SplitSkip confirmation:
1.
Offline tests
Make sure you are in offline mode:
QA Steps
Same as tests and verify there are no regressions for map/manual distance expense creation flows
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari