Refactor ConfirmModal usage to useConfirmModal in Search pages 2 #79908
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
a team and
roryabraham
and removed request for
a team
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
For
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ); | ||
| }, [contextMenuAnchor, handleContextMenuAnchorRef, styles, translate, activePolicy?.id, tripsFeatures]); | ||
|
|
||
| // Default 'Folder' lottie animation, along with its background styles |
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
ESLint rule disables must include a comment explaining why the rule is being disabled.
Suggested fix:
// Disabling preserve-manual-memoization because [explain the specific reason why manual memoization is needed]
// eslint-disable-next-line react-hooks/preserve-manual-memoization
const content: EmptySearchViewItem = useMemo(() => {
| selectedTransactions={selectedTransactions} | ||
| shouldPreventLongPressRow={isChat || isTask} | ||
| onDEWModalOpen={handleDEWModalOpen} | ||
| onDEWModalOpen={() => { |
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
Unnecessary wrapper function creates code duplication. handleDEWModalOpen can be passed directly.
Suggested fix:
onDEWModalOpen={handleDEWModalOpen}
|
No product considerations, removing my review |
2 participants
Explanation of Change
Refactor ConfirmModal usage to useConfirmModal in Search pages 2
Fixed Issues
$ #76694
PROPOSAL:
Tests
Precondition: Has at least one group workspace and the policy expense chat is disabled, and doesn't have any transaction
Create expensePrecondition: The approval mode of the workspace is
DYNAMIC_EXTERNALPrecondition: Have some saved searches
Offline tests
None
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-19.at.22.53.46.mov
Android: mWeb Chrome
Screen.Recording.2026-01-19.at.22.51.59.mov
iOS: Native
Screen.Recording.2026-01-19.at.22.54.32.mov
iOS: mWeb Safari
Screen.Recording.2026-01-19.at.22.48.12.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-06.at.23.55.28.mov
Screen.Recording.2025-12-06.at.23.59.14.mov
Screen.Recording.2025-12-07.at.00.00.24.mov