[LukasMod]

Explanation of Change

For testing react-native-onyx PR: Expensify/react-native-onyx#884

Only real change is pinning to onyx commit 40d1c56

Fixed Issues

$
PROPOSAL:

Tests

1. rm -rf node_modules && npm ci
2. Verify the pinned commit installed rather than the npm release:
   • grep -n '"react-native-onyx"' package.json returns github:Expensify/react-native-onyx#40d1c56c79faab96cb4149309a5f9ac8161b1a2f
   • grep -n 'react-native-onyx.git#' package-lock.json returns git+ssh://git@github.com/Expensify/react-native-onyx.git#40d1c56c79faab96cb4149309a5f9ac8161b1a2f
   • The installed version string is still 3.0.148, the same as the npm release, since package.json in the onyx repo is not bumped on every commit. The version alone does not prove the pin, so step 3 matters.
3. Verify the onyx#884 code is what actually runs. These are the new commit's own API, absent from npm's 3.0.148 and from the previous cb8bdd5:
   • grep -rln "addRemovedInOtherInstanceKey" node_modules/react-native-onyx/dist/ hits Onyx.js, OnyxCache.js, OnyxCache.d.ts
   • grep -rln "hasRemovedInOtherInstanceKey" node_modules/react-native-onyx/dist/ hits OnyxCache.js, OnyxCache.d.ts, OnyxSubscriptionManager.js
   • grep -rn "Sync removed a key while this tab was writing it" node_modules/react-native-onyx/dist/ returns nothing. That log was deliberate in cb8bdd5 and e057b8fb removed it.
   • grep -rn "Cache held no value for a key storage still has" node_modules/react-native-onyx/dist/ hits OnyxSubscriptionManager.js.
4. Run npm run web (or npm run desktop), sign in, and use the app normally: navigate chats, send a message, open a workspace. Verify the app boots and no Onyx.disconnect is not a function error appears in the console.
5. The remaining diagnostic goes through Onyx.registerLogger at level hmmm (src/Expensify.tsx:48) and surfaces as [Onyx] ... via Log.hmmm. It is expected to be rare rather than on every launch:
   • Cache held no value for a key storage still has: <key> fires once per collection key when the memory cache holds no value for a key that storage still has. Any platform. In this commit it is additionally silenced for keys another tab removed, which is the behaviour onyx#884 is testing, so the point of watching for it is that it should now appear less often than on cb8bdd5.
   • The Sync removed a key... message from the earlier pin no longer exists, so there is nothing to watch for there.
6. Native iOS, native Android and mWeb were not covered, so there are no screenshots below.

• Verify that no errors appear in the JS console

Offline tests

Not run. The cache-miss diagnostic reads from storage, so it is worth watching for the message above while going offline, navigating around, and reconnecting.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Testing build for an unpublished Onyx commit, not intended to merge. Adhoc builds install dependencies from the npm registry, so they would not pick up this pin.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested.

Android: mWeb Chrome

Not tested.

iOS: Native

Not tested.

iOS: mWeb Safari

Not tested.

MacOS: Chrome / Safari

Not tested in a browser. Verified locally with npm run typecheck, npm run lint-changed and npm run react-compiler-compliance-check check-changed (all green), plus Jest on the Onyx-heavy suites: OnyxUpdateManagerTest, MiddlewareTest, OnyxDerivedTest, SequentialQueueTest, OnyxDerivedRestoredValueTest, OnyxDerivedSelfHealTest (170 tests passed). lint-changed reports "No lintable files changed" since only package.json and package-lock.json differ from main.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 19 files with indirect coverage changes