Repository navigation
[No QA] Docs updates for E/A#98567 Add Plaid Connect and Fix statuses to Wallet - #105434
Conversation
… Wallet Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
| - **Active** with a **Connect to Plaid for a more accurate Expensify Card limit** message and a **Connect** action means the account is linked to the Expensify Card but isn't connected through Plaid. Select **Connect**, log into your bank through Plaid, and choose the matching bank account. | ||
| - **Active** with a **Fix your Plaid connection for a more accurate Expensify Card limit** message and a **Fix** action means the account's Plaid connection is broken. Select **Fix**, log into your bank through Plaid again, and choose the matching bank account. |
There was a problem hiding this comment.
We can simplify and combine these points into one.
| - **Active** with a **Connect to Plaid for a more accurate Expensify Card limit** message and a **Connect** action means the account is linked to the Expensify Card but isn't connected through Plaid. Select **Connect**, log into your bank through Plaid, and choose the matching bank account. | |
| - **Active** with a **Fix your Plaid connection for a more accurate Expensify Card limit** message and a **Fix** action means the account's Plaid connection is broken. Select **Fix**, log into your bank through Plaid again, and choose the matching bank account. | |
| - **Active** with a **Connect to Plaid for a more accurate Expensify Card limit** or **Fix your Plaid connection for a more accurate Expensify Card limit** message and a **Connect**/**Fix** action means the account isn't connected through Plaid or the account's Plaid connection is broken. Select **Connect**/**Fix**, log into your bank through Plaid, and choose the matching bank account. |
Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
PR Author Checklist
|
|
@MelvinBot mark this PR as ready for review |
|
This PR is now marked as ready for review. GitHub shows it is no longer a draft, and |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
A preview of your ExpensifyHelp changes have been deployed to https://8ed06e29.helpdot.pages.dev ⚡️ Updated articles: |
| - **Pending** with a **Please confirm test transactions** message and a **Confirm** action means the account was submitted and is waiting on test transactions. Click the account row to open **Validate your bank account**. If **Continue setup** and **Start over** appear first, click **Continue setup** to reach it. Learn how to [validate a business bank account](/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account). | ||
| - **Verifying** means Expensify is reviewing your documentation and no action is needed from you. | ||
| - **Locked** means the account requires attention before it can be used. Learn how to [unlock a business bank account](/articles/new-expensify/wallet-and-payments/Unlock-a-Business-Bank-Account). | ||
| - **Active** with a **Connect to Plaid for a more accurate Expensify Card limit** or **Fix your Plaid connection for a more accurate Expensify Card limit** message and a **Connect**/**Fix** action means the account isn't connected through Plaid or the account's Plaid connection is broken. Select **Connect**/**Fix**, log into your bank through Plaid, and choose the matching bank account. |
There was a problem hiding this comment.
Readability / deterministic writing: This bullet combines two distinct states (Connect vs. Fix) and uses slash notation (**Connect**/**Fix**), which conflicts with the surrounding list where each bullet describes a single status and action. The Deterministic Writing Rule (HELPSITE_NAMING_CONVENTIONS.md) calls for being literal, exact, and consistent. Consider splitting into two bullets matching the pattern of the others, e.g.:
- Active with a Connect to Plaid for a more accurate Expensify Card limit message and a Connect action means the account isn't connected through Plaid. Select Connect, then log into your bank through Plaid and choose the matching bank account.
- Active with a Fix your Plaid connection for a more accurate Expensify Card limit message and a Fix action means the account's Plaid connection is broken. Select Fix, then log into your bank through Plaid and choose the matching bank account.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single bullet to the existing "How business bank accounts appear in Wallet" status list in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@MelvinBot test this PR on web and post screenshots of the UI change |
|
🤖 Web test steps verification results: This PR only changes a help article, so it has no App UI change to capture. The tester could not open the help preview from the App session, and the test account's Wallet has no bank accounts, so the new Connect/Fix state can't appear there.
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.27-0 🚀
|

Explanation of Change
Help site update for Allow linking Plaid to an existing bank account and fixing existing Plaid connection.
New feature: In Account > Wallet, a US business bank account that is linked to the Expensify Card (the settlement account, or an account on a workspace on the Expensify Card waitlist) now shows a Connect action when it isn't connected through Plaid, and a Fix action when its Plaid connection is broken. Both open a new Connect to Plaid flow. The source PR has no beta gate.
Article updated:
docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md, section "How business bank accounts appear in Wallet". The existing list says:That list didn't cover an Active account that now shows a message and an action. I added two bullets to the existing list (no new sections or FAQs):
UI labels were checked against
src/languages/en.tsonmain(walletPage.bankAccountStatus.plaidConnectForLimit,walletPage.bankAccountStatus.plaidBrokenReconnect,walletPage.bankAccountStatus.connect,common.actionBadge.fix,walletPage.bankAccountStatus.active). The test account can't reach this state because it needs an Expensify Card settlement account, so the labels were not checked in the live UI.Fixed Issues
$ #98567
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@dominictb, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.