Make Use suggestion the main button when the AI rules builder refuses a rule by yuwenmemon · Pull Request #104942 · Expensify/App

yuwenmemon · 2026-10-25T22:35:39Z

Explanation of Change

When the AI rules builder refuses a description, the small Try this instead button didn't read as related to the suggestion. Following Danny's proposal, the refusal drops its "Rules can't do that." header, the explanation ends with "Try the suggestion below instead:", the suggestion shows in quotes, and a green Use suggestion button sits beside a neutral second button.

On New rule, the second button reads Create anyway and drafts the admin's own description as an agent rule, instead of sending it back to Concierge to be refused again. The editors' Describe modal has no agent rule to fall back to, so it keeps Next.

The form's submit button only comes in green or red, so FormProvider gets an opt-in isSubmitButtonNeutral prop. The backend sends impossible answers only after Web-Expensify#56886 merges, so the test steps swap in an answer locally.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/683438
PROPOSAL: N/A

Tests

Precondition: Paste the snippet below into the dev console after each page load.

As a workspace admin on a Control workspace, open Rules > New rule.
Run answer = {state: 'impossible', reason: 'noCapability', explanation: "Agents can't send text messages.", suggestedPrompt: 'When a report is submitted, send the approver a direct message that notifies them.'}.
Describe "Text the approver's phone whenever a report is submitted" and tap Next.
Verify the refusal has no "Rules can't do that." header, the explanation ends with "Try the suggestion below instead:", the suggestion shows in quotes, and a neutral Create anyway and a green Use suggestion sit side by side.

Create anyway and Use suggestion side by side on New rule, with no header above the explanation

5. Tap Create anyway. 6. Verify the agent rule page opens with your own description and a banner that includes the explanation.

7. Tap Back, then Discard changes, and repeat steps 2 and 3. 8. Run `answer = {state: 'agentRule', agentRulePrompt: 'When an expense report is submitted, send its approver a direct message notifying them that the report was submitted.'}`, then tap Use suggestion. 9. Verify the agent rule page opens with the reworded instruction.

10. Go back to New rule, open Flag for review, tap Describe, run the step 2 answer again, and describe the same rule. 11. Verify the modal shows a neutral Next and a green Use suggestion side by side.

Next and Use suggestion side by side in the editor's Describe modal, with no header above the explanation

12. Run `answer = {state: 'impossible', reason: 'noCapability', explanation: "Agents can't send text messages.", suggestedPrompt: ''}` and describe the rule again. 13. Verify only a green Next shows, because there is no suggestion to try.

Console snippet that swaps the GenerateRule answer locally

window.answer = null;
const originalSet = Onyx.set;
const originalMerge = Onyx.merge;
const originalUpdate = Onyx.update;
const swap = (value) => (value?.generationID && value.state && window.answer ? {generationID: value.generationID, ...window.answer} : value);
Onyx.set = (key, value) => originalSet(key, key === 'generatedRule' ? swap(value) : value);
Onyx.merge = (key, value) => originalMerge(key, key === 'generatedRule' ? swap(value) : value);
Onyx.update = (updates) => originalUpdate(updates.map((update) => (update.key === 'generatedRule' ? {...update, value: swap(update.value)} : update)));

Verify that no errors appear in the JS console

Offline tests

Repeat Tests steps 1–4, then go offline.
Verify Create anyway and Use suggestion are both disabled, the same as Next on New rule while offline.

QA Steps

Refusals reach staging only after Web-Expensify#56886 is live. Then:

Open Rules > New rule as a workspace admin on a Control workspace.
Describe "Text the approver's phone whenever a report is submitted" and tap Next.
Verify the suggestion shows in quotes, with a neutral Create anyway and a green Use suggestion side by side.
Tap Create anyway and verify the agent rule page opens with your description.
Go back, describe the rule again, tap Use suggestion, and verify the agent rule page opens with a rule that messages the approver.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-25T22:35:45Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-10-25T22:35:46Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-25T22:35:49Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T22:46:29.950156Z	`97068b7`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97068b76d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-25T22:46:27Z

+                        size={CONST.BUTTON_SIZE.LARGE}
+                        onPress={() => describeSuggestedRule(refusalSuggestedPrompt)}
+                        isDisabled={isOffline}
+                        style={styles.flex1}


Let the translated primary action use enough width

On narrow mobile screens, especially in locales with longer shipped labels such as German or Japanese, this flex1 combines with the submit button's flex1 to give each action only half of the row. Because Button.Text defaults to a single line, “Try this instead” is then ellipsized even though the much shorter Next button has unused space. Allow the buttons to size according to their labels or stack/wrap them at narrow widths.

Useful? React with 👍 / 👎.

(Yuwen's Agent) Fixed in fc22789. The two buttons now size to their labels and share the row, and they wrap onto two full-width rows when a translated label doesn't fit beside the other one.

dannymcclain · 2026-10-26T13:08:36Z

I can't quite put my finger on it exactly, but the suggestion flow feels a little confusing to me. The "Try this instead" button doesn't feel super related to the suggestion.

Would love to get @Expensify/design's thoughts here, but could we do something like this to make it more clear?

Agents can't send text messages. Try the suggestion below instead:

"When a report is submitted, send the approver a direct message that notifies them"
[ Create anyway / Next ] [ Use suggestion ]

shawnborton · 2026-10-26T14:18:05Z

Totally agree with that Danny, I really like what you are proposing above.

yuwenmemon · 2026-10-26T19:30:20Z

@dannymcclain @shawnborton updated! Check out the new screenhots in the PR description

shawnborton · 2026-10-26T20:11:22Z

I think Danny was suggesting to kinda combine this part rather than have it on two lines? But will let him confirm!

dubielzyk-expensify · 2026-10-26T22:44:24Z

Really like that suggestion, Danny.

yuwenmemon · 2026-10-26T23:21:52Z

@dannymcclain can you confirm? Remove the "Rules can't do that." header altogether?

garrettmknight · 2026-10-27T09:54:05Z

Might be moot if we're removing, but I was thinking of updating to 'Rules can't do that yet' and capturing the request somewhere to review? Could be a really great way to figure out what rules we don't support that people are asking for. Regardless of the copy, can we store these unsupported requests somewhere?

dannymcclain · 2026-10-27T13:08:48Z

Yeah I was suggesting removing the "Rules can't do that" header altogether. It feels a little... crude? Unrefined? I dunno how to say it haha, it just feels like we're REALLY calling attention to the limitation when I don't think we need to be so overt about it.

I don't feel super duper strongly if others disagree - I just think it stands out in a negative way and we don't really need it.

codecov · 2026-10-28T06:22:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Form/FormWrapper.tsx	`88.07% <100.00%> (-2.41%)`	⬇️
src/components/FormAlertWithSubmitButton.tsx	`97.91% <100.00%> (+0.77%)`	⬆️
src/pages/workspace/rules/DescribeRuleForm.tsx	`94.83% <100.00%> (+0.77%)`	⬆️
... and 4393 files with indirect coverage changes

yuwenmemon · 2026-10-28T06:26:07Z

Okay updated!

dannymcclain · 2026-10-28T14:44:10Z

LGTM!

yuwenmemon · 2026-10-28T16:39:59Z

@JS00001 / @rushatgabhane bump here!

Pujan92 · 2026-10-29T05:21:25Z

@yuwenmemon do I need to review this?

yuwenmemon added 2 commits October 25, 2026 15:22

feat(rules): make Try this instead the suggested button on a refusal

00ce89a

style(rules): put Next and Try this instead side by side

97068b7

yuwenmemon requested review from a team as code owners October 25, 2026 22:35

melvin-bot Bot assigned yuwenmemon Oct 25, 2026

melvin-bot Bot requested a review from Pujan92 October 25, 2026 22:35

melvin-bot Bot requested review from garrettmknight and removed request for a team October 25, 2026 22:35

melvin-bot Bot removed the request for review from a team October 25, 2026 22:35

chatgpt-codex-connector Bot reviewed Oct 25, 2026

View reviewed changes

feat(rules): offer Create anyway next to Try this instead on New rule

120398b

yuwenmemon requested review from JS00001 and rushatgabhane October 25, 2026 23:14

yuwenmemon added the Design label Oct 25, 2026

melvin-bot Bot requested a review from dannymcclain October 25, 2026 23:18

JS00001 previously approved these changes Oct 26, 2026

View reviewed changes

feat(rules): quote the suggestion and label its button Use suggestion

fc22789

yuwenmemon dismissed JS00001’s stale review via fc22789 October 26, 2026 19:15

yuwenmemon changed the title ~~Make Try this instead the main button when the AI rules builder refuses a rule~~ Make Use suggestion the main button when the AI rules builder refuses a rule Oct 26, 2026

chore(rules): merge main and move the offline check to Use suggestion

ec51398

style(rules): drop the refusal header and lead with the explanation

fa47a52

JS00001 approved these changes Oct 29, 2026

View reviewed changes

Conversation

yuwenmemon commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 25, 2026

Uh oh!

melvin-bot Bot commented Oct 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Oct 26, 2026

Uh oh!

shawnborton commented Oct 26, 2026

Uh oh!

yuwenmemon commented Oct 26, 2026

Uh oh!

shawnborton commented Oct 26, 2026

Uh oh!

dubielzyk-expensify commented Oct 26, 2026

Uh oh!

yuwenmemon commented Oct 26, 2026

Uh oh!

garrettmknight commented Oct 27, 2026

Uh oh!

dannymcclain commented Oct 27, 2026

Uh oh!

codecov Bot commented Oct 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yuwenmemon commented Oct 28, 2026

Uh oh!

dannymcclain commented Oct 28, 2026

Uh oh!

yuwenmemon commented Oct 28, 2026

Uh oh!

Pujan92 commented Oct 29, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yuwenmemon commented Oct 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 25, 2026 •

edited

Loading

codecov Bot commented Oct 28, 2026 •

edited by github-actions Bot

Loading