Repository navigation
[No QA] Wait for each onboarding screen in the web onboarding macro - #104937
Draft
kacper-mikolajczak wants to merge 3 commits into
Draft
kacper-mikolajczak wants to merge 3 commits into
kacper-mikolajczak wants to merge 3 commits into
Conversation
…ding macro The purpose chooser sizes its max height to the window, so at the default browser viewport the last option sits below the fold and the press is dispatched off-screen. Also drop the wait stable line, which did not change the outcome.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The automated onboarding replay presses
Something elsewhile the purpose chooser is still settling. The press lands before the button is interactive, the flow never reaches the name step, and the replay diverges. Add waits in the web onboarding macro so each press fires only once its target screen is present:agent-device wait <selector> 15000before both presses, pluswait stable 1000 10000between the chooser wait and its press.Fixed Issues
$ PROPOSAL:
Tests
agent-deviceflowcomplete-onboardingwith a first and last name).QA Steps
No staging QA: the change is inside a development-only automation flow file (
.claude/skills/agent-device/flows/), not shipped app code.