Repository navigation
[No QA] Bump sharp and wrangler in /web/cloudflare-worker - #104924
Merged
Merged
Conversation
Recreates Dependabot PR 104913 so CI runs with repository secrets. Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
roryabraham
marked this pull request as ready for review
October 24, 2026 07:09
roryabraham
requested review from
AndrewGable,
justinpersaud and
roryabraham
as code owners
October 24, 2026 07:09
roryabraham
approved these changes
Oct 24, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
justinpersaud
approved these changes
Oct 24, 2026
Contributor
|
🚧 justinpersaud has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Patches a HIGH security vulnerability.
Recreates [No QA] Bump sharp and wrangler in /web/cloudflare-worker from a MelvinBot branch. The changes are byte-for-byte identical to that PR:
wranglergoes from 4.144.0 to 4.152.0, andsharpgoes from 0.35.4 to 0.35.5 inweb/cloudflare-worker.Why recreate it: GitHub does not give repository secrets to workflows that Dependabot triggers. The
Remote Build AndroidandRemote Build iOSworkflows on that PR failed at checkout becausesecrets.OS_BOTIFY_TOKENwas empty. Pushing the same change from a non-Dependabot branch lets those workflows run normally.Local checks in
web/cloudflare-worker:npm ci,npm run typecheck, andnpm test(33/33 passed).Fixed Issues
$
PROPOSAL:
Tests
None.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari