Repository navigation
[No QA] Make the Cloudflare Worker the only web deploy - #104865
Open
justinpersaud wants to merge 4 commits into
Open
justinpersaud wants to merge 4 commits into
justinpersaud wants to merge 4 commits into
Conversation
new.expensify.com and staging.new.expensify.com are served by the Cloudflare Worker, so the webDeploy job no longer changes what users get, and its zone cache purge doesn't reach Worker responses: a new Worker version takes effect immediately. The deploy's web result now comes from the Worker job alone.
justinpersaud
marked this pull request as ready for review
October 23, 2026 15:22
justinpersaud
requested review from
a team,
AndrewGable and
roryabraham
as code owners
October 23, 2026 15:22
melvin-bot
Bot
requested review from
nyomanjyotisa
and removed request for
a team
October 23, 2026 15:22
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AndrewGable
previously approved these changes
Oct 23, 2026
roryabraham
requested changes
Oct 24, 2026
| @@ -831,8 +763,7 @@ jobs: | |||
|
|
|||
| webDeployWorker: | |||
Contributor
There was a problem hiding this comment.
Nit: can we please rename this job to webDeploy now that the old webDeploy job is gone?
It is the only web deploy job now.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
webDeployjob: new.expensify.com and staging.new.expensify.com are both served by the Cloudflare Worker now, so that job no longer changes what users get. The Worker deploy job (webDeployWorker) is the only web deploy and decides the deploy's web result.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/688126
PROPOSAL:
Tests
Offline tests
None. This only changes the deploy workflow.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
No QA. This changes the deploy workflow, which the deploys themselves verify.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari