Repository navigation
Migrate the PR-testing Cloudflare Worker to App - #104801
Draft
roryabraham wants to merge 1 commit into
Draft
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Finish the repository migration by moving the shared
*.pr-testing.expensify.comWorker into App. Staging and production already live here, but PR testing still depends on Cloudflare-Workers for its code and deployments.Companion cleanup PR (merge only after this is deployed and verified): https://github.com/Expensify/Cloudflare-Workers/pull/272
wrangler.pr-testing.jsonctargeting the existingpr-testing-expensifyWorker. Preserve its compatibility date and existing wildcard route; no account ID or credentials are committed.Cache-Control: no-cache, avoiding stale-body/new-nonce mismatches.mainand the same deployer teams as the old repository. Add six integration tests running the bundled PR-testing Worker in workerd with intercepted S3 requests.Deployment / merge order
CLOUDFLARE_WORKERS_DEPLOY_TOKENto edit the existingpr-testing-expensifyWorker.CLOUDFLARE_ACCOUNT_IDand the existing App actor-validation token remain GitHub secrets.main.No live deployment, route change or token change was performed for this draft. The workflow remains manual, like the old repository's workflow.
AI Tests
npm ci,npm run typecheck, andnpm test(31 tests, including all existing staging/production tests).npx wrangler deploy --dry-run --config wrangler.pr-testing.jsonc(no uploads or credentials).npm run lint-changed,npm run spell-changed, changed-workflowactionlint(custom Blacksmith runner-label warning ignored), andgit diff --check.verifyActions.shcould not produce a clean comparison with the reused/symlinked root dependencies: rebuilding unrelated JavaScript actions changes embedded dependency paths to../../App/node_modules. Those generated changes were discarded; no action bundles are changed by this PR. CI should verify this with a clean root install.npm auditreports three pre-existing high-severity findings in the pinned Wrangler → Miniflare → sharp development dependency chain. No dependency versions were upgraded; Miniflare is now explicitly declared for the tests at the exact version already in the lockfile.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari