Skip to content

Migrate the PR-testing Cloudflare Worker to App - #104801

Draft
roryabraham wants to merge 1 commit into
mainfrom
rory/migrate-pr-testing-worker
Draft

roryabraham wants to merge 1 commit into
mainfrom
rory/migrate-pr-testing-worker

Conversation

@roryabraham

@roryabraham roryabraham commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Finish the repository migration by moving the shared *.pr-testing.expensify.com Worker into App. Staging and production already live here, but PR testing still depends on Cloudflare-Workers for its code and deployments.

Companion cleanup PR (merge only after this is deployed and verified): https://github.com/Expensify/Cloudflare-Workers/pull/272

  • Add a separate wrangler.pr-testing.jsonc targeting the existing pr-testing-expensify Worker. Preserve its compatibility date and existing wildcard route; no account ID or credentials are committed.
  • Keep the current S3 origin, per-PR directory selection, ad-hoc build uploads, SPA fallback and edge-cache rules. This does not switch PR builds to Workers Static Assets or create a Worker per PR.
  • Share security headers, nonce generation and CSP definitions with the staging/production Worker. PR testing keeps its own font/frame origins and uses the App template's inline-script hashes. Rewritten HTML drops validators and gets Cache-Control: no-cache, avoiding stale-body/new-nonce mismatches.
  • Add a manual deployment workflow restricted to main and the same deployer teams as the old repository. Add six integration tests running the bundled PR-testing Worker in workerd with intercepted S3 requests.

Deployment / merge order

  1. Extend CLOUDFLARE_WORKERS_DEPLOY_TOKEN to edit the existing pr-testing-expensify Worker. CLOUDFLARE_ACCOUNT_ID and the existing App actor-validation token remain GitHub secrets.
  2. Merge this PR, then run Deploy PR-testing Cloudflare Worker on main.
  3. Verify two existing PR hosts, a deep link, service-worker updates and rebuilding the same PR without stale HTML/CSP errors.
  4. Only then merge the companion Cloudflare-Workers cleanup PR. Keep the live Worker, wildcard route and S3 bucket intact. Disconnect any old Workers Builds integration during handoff.

No live deployment, route change or token change was performed for this draft. The workflow remains manual, like the old repository's workflow.

AI Tests

  • Passed on Node 26.12.1: standalone Worker npm ci, npm run typecheck, and npm test (31 tests, including all existing staging/production tests).
  • Passed: npx wrangler deploy --dry-run --config wrangler.pr-testing.jsonc (no uploads or credentials).
  • Passed: root npm run lint-changed, npm run spell-changed, changed-workflow actionlint (custom Blacksmith runner-label warning ignored), and git diff --check.
  • verifyActions.sh could not produce a clean comparison with the reused/symlinked root dependencies: rebuilding unrelated JavaScript actions changes embedded dependency paths to ../../App/node_modules. Those generated changes were discarded; no action bundles are changed by this PR. CI should verify this with a clean root install.
  • npm audit reports three pre-existing high-severity findings in the pinned Wrangler → Miniflare → sharp development dependency chain. No dependency versions were upgraded; Miniflare is now explicitly declared for the tests at the exact version already in the lockfile.
  • Full React Native/Jest/Storybook suites were not run: this is confined to the standalone Worker package and workflows, not application UI code. Live rollout verification remains pending.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham
roryabraham requested a review from a team October 22, 2026 20:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant