Repository navigation
Retype a leftover non-distance draft as distance on the distance start page - #104792
Open
aimane-chnaif wants to merge 3 commits into
Open
aimane-chnaif wants to merge 3 commits into
aimane-chnaif wants to merge 3 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
October 23, 2026 00:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
trjExpensify
approved these changes
Oct 23, 2026
trjExpensify
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The user is starting over by longing pressing again, so makes sense they start afresh 👍
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Home-screen shortcuts open the create pages by URL, so the shared draft from an unfinished expense is still there.
DistanceRequestStartPagetook its request type from that draft, so a leftover Manual draft was typedmanual, and the reset skipped it because the type already matched.The old amount then survived into the next Create expense, and the Map tab had no waypoints, so tapping Start opened the "not here" page.
Now a non-distance draft type is ignored and the type comes from the selected tab, so the reset rebuilds the draft as a distance draft.
Fixed Issues
$ #101340
Tests
Precondition:
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
test.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test.mov