Skip to content

Retype a leftover non-distance draft as distance on the distance start page - #104792

Open
aimane-chnaif wants to merge 3 commits into
Expensify:mainfrom
aimane-chnaif:fix-101340
Open

aimane-chnaif wants to merge 3 commits into
Expensify:mainfrom
aimane-chnaif:fix-101340

Conversation

@aimane-chnaif

@aimane-chnaif aimane-chnaif commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Home-screen shortcuts open the create pages by URL, so the shared draft from an unfinished expense is still there.
DistanceRequestStartPage took its request type from that draft, so a leftover Manual draft was typed manual, and the reset skipped it because the type already matched.
The old amount then survived into the next Create expense, and the Map tab had no waypoints, so tapping Start opened the "not here" page.
Now a non-distance draft type is ignored and the type comes from the selected tab, so the reset rebuilds the draft as a distance draft.

Fixed Issues

$ #101340

Tests

Precondition:

  • Platform: Android
  • Keep the app in the background between steps (do not kill it).
  • Open Track distance once and select the Map tab.
  1. Long press the app icon and tap Create expense.
  2. Enter 25 and press the Android Home button.
  3. Long press the app icon and tap Track distance.
  4. Tap Start and verify the address search opens (not "Hmm... it's not here"). Go back and press Home.
  5. Long press the app icon and tap Create expense.
  6. Verify the amount is empty.
  7. Enter 30 and press Home.
  8. Long press the app icon and tap Track distance, then press Home.
  9. Long press the app icon and tap Create expense.
  10. Verify the amount is empty (30 is not pre-filled).
  11. Tap + > Track distance, create a Map distance expense and verify it is created.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
test.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test.mov

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/iou/request/DistanceRequestStartPage.tsx 92.00% <66.66%> (+0.10%) ⬆️
... and 12 files with indirect coverage changes

@aimane-chnaif
aimane-chnaif marked this pull request as ready for review October 23, 2026 00:34
@aimane-chnaif
aimane-chnaif requested review from a team as code owners October 23, 2026 00:34
@melvin-bot
melvin-bot Bot requested review from situchan and removed request for a team October 23, 2026 00:34
@melvin-bot

melvin-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team October 23, 2026 00:34
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T00:34:16.049280Z b48cfa4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The user is starting over by longing pressing again, so makes sense they start afresh 👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants