Skip to content

[No QA] Return 404 when the Cloudflare Worker's previous builds bucket can't be read - #104769

Merged
justinpersaud merged 2 commits into
mainfrom
jpersaud-worker-r2-errors
Oct 22, 2026
Merged

[No QA] Return 404 when the Cloudflare Worker's previous builds bucket can't be read#104769
justinpersaud merged 2 commits into
mainfrom
jpersaud-worker-r2-errors

Conversation

@justinpersaud

@justinpersaud justinpersaud commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

When a script, style or image the current build doesn't have is requested, the Cloudflare Worker looks it up in the previous builds bucket (R2). If R2 returned an error, for example a transient internal error or a key it rejects, the Worker threw, so the request ended in an exception and a 500. That happened once on staging this week.

Now the Worker logs the error and answers 404, as it does for a file no build has. The tab gets the same ChunkLoadError as before and recovers with a reload, but the failure shows up as a logged error instead of an exception.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/688126
PROPOSAL:

Tests

  1. In web/cloudflare-worker, run npm test and npm run typecheck, and verify all 24 tests and the typecheck pass.
  2. Verify the new test returns 404 when the previous builds bucket fails passes. It requests a chunk path over R2's 1,024-byte key limit, so the bucket lookup fails, with GET and HEAD.
  3. Put a build in dist/, run npm run dev, and request http://localhost:8787/<1,100 characters>.bundle.js. Verify it returns 404 with the security headers, and the terminal logs Failed to read … from the previous builds bucket.
  • Verify that no errors appear in the JS console

Offline tests

None. This only changes the Worker's response when its storage fails.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

No QA. The failure can't be triggered on demand, and the unit test covers it.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@justinpersaud
Return 404 when the previous builds bucket can't be read
5b55026 
An R2 error while looking up a file from a previous build made the Worker throw, so the request failed with an exception. It now logs the error and answers like any file no build has, so the tab gets a ChunkLoadError and recovers with a reload.
@justinpersaud
Document the 404 when the previous builds bucket can't be read
e1820b8
@justinpersaud
justinpersaud marked this pull request as ready for review October 22, 2026 16:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T16:26:38.844298Z e1820b8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@justinpersaud
justinpersaud merged commit 145a2e8 into main Oct 22, 2026
54 of 56 checks passed
@justinpersaud
justinpersaud deleted the jpersaud-worker-r2-errors branch October 22, 2026 17:46
@OSBotify

OSBotify commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🚧 justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104769.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-145a2e8-d34f344-b3b56f4ba852ede6addb2417b3446e97cca3f788/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-145a2e8-d34f344-7969f1c19f4a9270ace0bc0fca9c22ca261bd49a/index.html
Android iOS
Web 🕸️
https://104769.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Oct 23, 2026
Open
@OSBotify

OSBotify commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes
@roryabraham roryabraham roryabraham approved these changes

Assignees

@justinpersaud justinpersaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinpersaud @OSBotify @AndrewGable @roryabraham