[Krishna2323]

Explanation of Change

Reorganizes the Search Filters list for Expense, Expense report, Invoice, and Trip into seven sections: Core, Details, Card transactions, Report fields, Report actions, Exports, and Withdrawals.

• Moves Keyword up to the Core section.
• Renames the Invoice date filter to Created date.
• Adds a Search filters input on both the web popover and mobile page.
• Filters by name while keeping matches grouped in their original sections.
• Shows No results found when there are no matches.
• On web, clears the right pane if its selected filter no longer matches the search.

Fixed Issues

$ #104330
PROPOSAL: N/A

Tests

1. Go to Spend > Expenses and click Filters.
2. Verify Keyword is the last row in the Core section, right after Workspace if it is shown.
3. Verify the filters appear in this order:
   • Core: Core filters, including Workspace and Keyword
   • Details: Amount, Currency, Date, etc.
   • Card transactions: Card, Feed, Posted, etc.
   • Report fields: Report ID, Report field, Custom field 1, Custom field 2
   • Report actions: Submitted, Rejected, Held, Approved, Any approval, Paid, Paid by
   • Exports: Exported, Exported to
   • Withdrawals
4. Use an account with no cards. Verify the Card transactions section is hidden and there are no consecutive dividers.
5. Change Type to Invoice. Verify:
   • The date filter is labelled Created date.
   • Total, Title, and Report ID no longer appear with the report action dates.
6. Type paid in the search input. Verify only Paid and Paid by appear, each in its own section.
7. Type xyz. Verify No results found appears and the right pane is empty (web only).
8. Clear the search input. Verify the full filter list returns.
9. On a narrow layout, open Filters, type paid, open Paid, then go back. Verify paid remains in the search input.
10. Verify that no errors appear in the JS console.

Offline Tests

• Repeat the tests above while offline. Verify the filter list and search work as expected.

QA Steps

• Repeat the tests above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_mWeb.mp4

iOS: mWeb Safari

ios_native.mp4

MacOS: Chrome / Safari

web_chrome.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

[JmillsExpensify]

Assigning @daledah to help with prompt review of the PR when it's ready.

[melvin-bot]

@gijoe0295 @JS00001 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-25T21:39:10.826447Z We couldn’t complete this review. Comment @codex review to try again.	2cb47a5	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Krishna2323]

@gijoe0295 sorry for the bump, @daledah will review this one.

[daledah]

@JmillsExpensify @JS00001 could you please help to run Generate static translations GitHub workflow here?

[daledah]

@Krishna2323 Native: the first tap on a filter row only closes the keyboard

bug.mov

[shawnborton]

TBH, I think the issue is that the filter search should be on top of everything. Describe your search is just a filter option at the end of the day.

This was my first gut reaction as well - move the little search/find input to the very top above all of the filter rows.

[JS00001]

TBH, I think the issue is that the filter search should be on top of everything. Describe your search is just a filter option at the end of the day.

This is what I thought when I saw that as well, I think it makes sense to move the search bar up

[dannymcclain]

Totally agree with moving the search bar up.

[JmillsExpensify]

Cool. @Krishna2323 are you ready for another round of reviews?

[daledah]

@JmillsExpensify checking again now

[daledah]

@Krishna2323 Could you please update the translations based on this comment and take a look at my comment here?

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nents/Search/FilterDropdowns/FilterPopupButton.tsx	100.00% <100.00%> (ø)
src/hooks/useAdvancedSearchFilters.ts	97.82% <ø> (ø)
src/libs/SearchUIUtils.ts	74.33% <100.00%> (+0.05%)	⬆️
src/pages/Search/SearchNLFilterPage.tsx	0.00% <ø> (ø)
...mponents/AdvancedFilters/SearchNLFilterContent.tsx	0.00% <0.00%> (ø)
...lterDropdowns/SearchAdvancedFiltersPopup/index.tsx	97.85% <96.61%> (+4.52%)	⬆️
...h/SearchPageHeader/SearchAdvancedFiltersButton.tsx	53.84% <20.00%> (-4.98%)	⬇️
...hAdvancedFiltersPage/SearchAdvancedFiltersBase.tsx	0.00% <0.00%> (ø)
...ch/FilterComponents/AdvancedFilters/FilterList.tsx	0.00% <0.00%> (ø)
... and 59 files with indirect coverage changes

[Krishna2323]

@Expensify/design @JmillsExpensify Updated based on the feedback:

• The "Search filters" input now sits at the very top, above "Describe your search", in both the popover and the narrow-layout page.
• "Describe your search" is now treated like any other filter in search: it only shows if its label matches what's typed. So in the case above (Describe active, then a search that matches nothing), you now get the "No filters selected" empty state. If the search matches a filter, the first match is shown.
• Since "Describe your search" is now the first row, the popover opens with it selected, and typing something that matches it (e.g. "des") selects it as the first match. Its input no longer grabs focus when shown, so you can keep typing in "Search filters". Click into the describe field to start typing there, same as the other text filters.

One question: "Describe your search" is currently pinned along with the search input, so the rest of the filters scroll under it (same as on main today). Since it's now just another filter option, should it scroll with the list instead, leaving only the "Search filters" input pinned? I'd lean towards scrolling.

@daledah translations are updated, and the native issue where the first tap on a filter row only closed the keyboard is fixed.

web_chrome.mp4

[shawnborton]

Since it's now just another filter option, should it scroll with the list instead, leaving only the "Search filters" input pinned? I'd lean towards scrolling.

This is where I lean towards too, just have it act as a filter like the others.

[dannymcclain]

Since it's now just another filter option, should it scroll with the list instead, leaving only the "Search filters" input pinned? I'd lean towards scrolling.

This is where I lean towards too, just have it act as a filter like the others.

Yeah same - down to let it scroll with the rest.

[Krishna2323]

Updated:

Monosnap.screencast.2026-10-27.18-22-23.mp4

[shawnborton]

Looks good 👍

[Krishna2323]

@Expensify/design @JmillsExpensify One more thing I noticed while testing: keyboard navigation in the filters popover is pretty rough today. The arrow keys don't move through the filter list, and while you're typing in "Search filters" they can end up moving the selection inside the right pane instead.

I prototyped a fix locally (video below) with this behavior:

Where focus is	Key	What happens
"Search filters" input	↑ / ↓	Moves through the filter rows (incl. "Describe your search") and shows each one on the right. Focus stays in the input, so you can keep typing.
Left list	→ or Enter	Moves focus into the selected filter on the right
Right pane	← or Esc	Goes back to the filter list (Esc doesn't close the popover from here)
Left list	Esc	Closes the popover, as today
Right pane	↑ / ↓	Navigates within that filter's options, as today

Does this feel right to you? If so, I'd suggest we handle it in a separate issue/PR. Doing it properly touches the shared filter content components (to keep focus in sync between the two panes).

Monosnap.screencast.2026-10-27.18-52-16.mp4

[JmillsExpensify]

Love thinking about this. That feels right to me, though we can also hash it out in another PR. I've created a separate issue for it here: #105134

[JmillsExpensify]

Everything else looks good to me, including the recent changes. @Krishna2323 are you ready for another round of reviews?

[Krishna2323]

Yes, it's ready for review.

[github-actions]

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104668 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://104668.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[JmillsExpensify]

Tests really well on my end

[daledah]

LGTM