Repository navigation
[No QA] Docs updates for E/A#102380 Update bulk remove members steps for selection bar - #104634
Conversation
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@shubham1206agra @Krishna2323 @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| 4. Choose **Remove Member(s)**. | ||
| 5. Confirm by clicking **Remove**. | ||
| 3. On web, select **Remove members** from the selection bar. On mobile, select **[number] selected** at the top, then select **Remove members**. | ||
| 4. Confirm by clicking **Remove**. |
There was a problem hiding this comment.
Prohibited action verb: Do not use "clicking." Per the naming conventions (Actions) and authoring guidelines (Section 5), use select for UI interactions. Change to: 4. Confirm by selecting **Remove**.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted fix to the "Remove Multiple Members" procedure in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@stephanieelliott looks like this was merged without a test passing. These checks had not passed on acab018 when it was merged:
Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.24-1 🚀
|
Explanation of Change
Offer the workspace members bulk actions in the floating bar moved the Members page bulk actions on web from the header dropdown into a selection bar over the members list. The header no longer turns into a dropdown when members are selected. On mobile, the [number] selected dropdown in the header still holds the actions.
This made this step in Managing Workspace Members incorrect:
This PR replaces those two steps with one step that points web users to the selection bar and mobile users to the [number] selected dropdown. It also uses the exact UI label, Remove members. No other content changed.
UI labels were checked against
src/languages/en.tsand the live web UI (dev build):@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #101898
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari