Skip to content

[No QA] Docs updates for E/A#102380 Update bulk remove members steps for selection bar - #104634

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsBulkRemoveMembersSelectionBar
Oct 26, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsBulkRemoveMembersSelectionBar

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Offer the workspace members bulk actions in the floating bar moved the Members page bulk actions on web from the header dropdown into a selection bar over the members list. The header no longer turns into a dropdown when members are selected. On mobile, the [number] selected dropdown in the header still holds the actions.

This made this step in Managing Workspace Members incorrect:

  1. Click the green dropdown arrow in the top-right.
  2. Choose Remove Member(s).

This PR replaces those two steps with one step that points web users to the selection bar and mobile users to the [number] selected dropdown. It also uses the exact UI label, Remove members. No other content changed.

UI labels were checked against src/languages/en.ts and the live web UI (dev build):

Members page with one member selected and the selection bar showing Change role and Remove member

Members page with two members selected and the selection bar showing Remove members

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #101898
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 21, 2026 20:15
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 21, 2026
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#102380 Update bulk remove members steps for selection bar [No QA] Docs updates for E/A#102380 Update bulk remove members steps for selection bar Oct 26, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review October 26, 2026 20:32
@melvin-bot

melvin-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T21:24:17.294074Z
We couldn’t complete this review. Comment @codex review to try again.
acab018 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from Krishna2323, joekaufmanexpensify and shubham1206agra and removed request for a team October 26, 2026 20:32
@melvin-bot

melvin-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

@shubham1206agra @Krishna2323 @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott
stephanieelliott merged commit 4d2ebc1 into main Oct 26, 2026
21 of 22 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsBulkRemoveMembersSelectionBar branch October 26, 2026 20:33
4. Choose **Remove Member(s)**.
5. Confirm by clicking **Remove**.
3. On web, select **Remove members** from the selection bar. On mobile, select **[number] selected** at the top, then select **Remove members**.
4. Confirm by clicking **Remove**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prohibited action verb: Do not use "clicking." Per the naming conventions (Actions) and authoring guidelines (Section 5), use select for UI interactions. Change to: 4. Confirm by selecting **Remove**.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted fix to the "Remove Multiple Members" procedure in Managing-Workspace-Members.md. It replaces color-based and inaccurate UI instructions ("green dropdown arrow", "Remove Member(s)") with correct, platform-specific steps that use the selection bar and the proper button label Remove members. This is a clear quality improvement that aligns the removal flow with current governance and the actual UI.

Scores Summary

  • Readability: 8/10 - Steps are sequential, action-oriented, and easy to scan. The combined web/mobile sentence in step 3 is slightly dense but remains clear.
  • AI Readiness: 8/10 - Uses UI-exact labels and names platforms explicitly, which improves retrieval. No heading or metadata changes were proposed, so this is scoped to step content.
  • Style Compliance: 7/10 - Big improvement over the prior text: correctly adopts "selection bar," drops the color-only reference, and fixes the button label. Two residual issues remain in the changed lines.

Key Findings

  • Positive: Removes the prohibited color-only identifier ("green dropdown arrow") and the fabricated label "Remove Member(s)," replacing them with the UI-exact Remove members and the correctly-named selection bar.
  • Positive: Platform differences are now stated explicitly ("On web..." / "On mobile...") rather than assuming parity.
  • Issue (Style): Step 4 still reads "Confirm by clicking Remove." Per HELPSITE_NAMING_CONVENTIONS.md, use select, never "click." This is a modified line in the diff, so it is in scope.
  • Issue (Style): In step 3, the inline "On web... On mobile..." pattern is used. Governance prefers separate labeled "On web:" / "On mobile:" instructions when navigation differs. A single bolded dynamic label such as the selected count is acceptable for the mobile entry point, but the two platforms would be clearer as distinct lines.

Recommendations

  • Change "Confirm by clicking Remove" to "Confirm by selecting Remove" to comply with the select/choose rule.
  • Consider splitting step 3 into labeled "On web:" and "On mobile:" instructions per the Platform Instructions rule for clearer cross-platform guidance.
  • Optional consistency: the adjacent "Remove a Single Member" steps still use "click," but those lines are unchanged and out of scope for this PR.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md - Approve with minor changes. The removal-flow fix is a net improvement; address the "clicking" wording in step 4.

Note: Detailed line-by-line feedback has been provided as inline comments.

@melvin-bot melvin-bot Bot added the Emergency label Oct 26, 2026
@melvin-bot

melvin-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

@stephanieelliott looks like this was merged without a test passing. These checks had not passed on acab018 when it was merged:

  • review (still running when checked)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.24-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants