Skip to content

[No QA] Docs updates for E/A#83733 Document merchant= operator for exact merchant matches - #104125

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsMerchantExactMatchOperator
Nov 3, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsMerchantExactMatchOperator

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for #83733, which added a Contains / Equal to match type to the Merchant filter and a new merchant= search operator for exact merchant matches.

New feature: exact merchant matching with merchant=. The Use Search Operators to Filter and Analyze article only listed merchant::

| merchant: | Filter by expense merchant name | merchant:"Delta Air Lines" |

What changed: That one table row now lists merchant: / merchant=. It explains that merchant: matches merchant names that contain the value, and merchant= matches the exact merchant name only. No other content was added.

Fixed Issues

$ #83733
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@HiepPP, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Phuoc Hiep <HiepPP@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 15, 2026 17:10
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 15, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsMerchantExactMatchOperator
git checkout -b claude-docsMerchantExactMatchOperator upstream/claude-docsMerchantExactMatchOperator
git push -u origin claude-docsMerchantExactMatchOperator

Then you can close this PR and open a new one from your fork.

@github-actions github-actions Bot changed the title Docs updates for E/A#83733 Document merchant= operator for exact merchant matches [No QA] Docs updates for E/A#83733 Document merchant= operator for exact merchant matches Oct 15, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://5a95e2eb.helpdot.pages.dev ⚡️

Updated articles:

@HiepPP

HiepPP commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

hi @MelvinBot I reviewed the docs change and it looks good to me, it reflects the current behavior. I don't have permission to change the PR status, could you please mark this PR as Ready for review? Thank you

@HiepPP

HiepPP commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@stephanieelliott stephanieelliott self-assigned this Oct 28, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review October 28, 2026 19:31
@stephanieelliott
stephanieelliott self-requested a review as a code owner October 28, 2026 19:31
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @JmillsExpensify

@melvin-bot
melvin-bot Bot requested a review from JmillsExpensify October 28, 2026 19:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T20:32:23.363060Z
We couldn’t complete this review. Comment @codex review to try again.
6997b6c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team October 28, 2026 19:31
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

@JmillsExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, focused change to Use-Search-Operators-to-Filter-and-Analyze.md. It updates the merchant: row of the search operators reference table to document a new exact-match variant, merchant=, and clarifies the behavioral difference between the two: merchant: matches merchant names that contain the value, while merchant= matches the exact merchant name only. The example is updated to merchant="Delta Air Lines". The change is small, well-scoped, and consistent with the surrounding table (which already documents multiple syntax variants like amount: / purchase-amount:).

Scores Summary

  • Readability: 9/10 - The added description is clear and the contains-vs-exact distinction is explained plainly in a single sentence. Table formatting is consistent with existing rows.
  • AI Readiness: 9/10 - The change sits under a task-based ## How to filter expenses using search operators heading, uses UI-exact operator syntax, and reinforces real search intent (filtering by exact merchant name). No metadata or heading structure is affected by the diff.
  • Style Compliance: 9/10 - Follows the existing reference-table convention, uses backtick code formatting consistently, and bolds referenced UI filters per naming conventions. No prohibited language introduced.

Key Findings

  • Positive: Documenting both operator variants in one row (mirroring the amount: / purchase-amount: pattern) keeps the table consistent and discoverable.
  • Positive: The added sentence disambiguates substring vs. exact matching, which is exactly the kind of confusion a reader would hit.
  • Minor: Consider confirming that merchant= requires quotes for multi-word values, and whether the earlier quoting note (about spaces/commas) applies equally to the = form. If so, no change is needed; if not, a brief clarification could help.
  • Minor: Both example cells for merchant now use =. Keeping one : example and one = example could better illustrate both variants at a glance.

Recommendations

  • No blocking issues. The change is accurate, in scope, and compliant with the governance guidelines.
  • Optional: Show one example per operator variant (one merchant: and one merchant=) to visually reinforce the distinction.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md - Approved. Single-line table update documenting the merchant= exact-match operator. Clear and compliant.

Note: This change is a one-line table edit; detailed inline commentary is not warranted beyond the summary above.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanieelliott
stephanieelliott merged commit e1f6514 into main Nov 3, 2026
24 of 25 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsMerchantExactMatchOperator branch November 3, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants