Skip to content

[Hold E/E #678279] Add grokmcp connector - #101307

Open
rushatgabhane wants to merge 7 commits into
Expensify:mainfrom
rushatgabhane:add-grokmcp-connector
Open

rushatgabhane wants to merge 7 commits into
Expensify:mainfrom
rushatgabhane:add-grokmcp-connector

Conversation

@rushatgabhane

@rushatgabhane rushatgabhane commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Add Grok as the fourth connector on the Workspace → MCP page in NewDot. This includes the Grok icon, localized copy, and link to the Grok MCP setup guide.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/681777
PROPOSAL:

Tests

  1. Open NewDot as a workspace admin.
  2. Navigate to Workspace → MCP.
  3. Confirm Grok appears as the fourth connector.
  4. Confirm the Grok icon, title, subtitle, and Connect button are visible.
  • Verify that no errors appear in the JS console

Offline tests

No offline testing performed.

QA Steps

  1. Create a workspace and open Workspace → MCP.
  2. Verify that Grok appears as the fourth connector with its icon, title, and subtitle.
  3. Click the Grok Connect button and verify it points to the Grok MCP setup guide.
  • Verify that no errors appear in the JS console

    PR Author Checklist

    • I linked the correct issue in the ### Fixed Issues section above
    • I wrote clear testing steps that cover the changes made in this PR
      • I added steps for local testing in the Tests section
      • I added steps for the expected offline behavior in the Offline steps section
      • I added steps for Staging and/or Production testing in the QA steps section
      • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if
        the entered data is not correct)
      • I turned off my network connection and tested it while offline to ensure it matches the expected
        behavior (i.e. verify the default avatar icon is displayed if app is offline)
      • I tested this PR with a [High Traffic account](https://github.com/Expensify/App/blob/main/
        contributingGuides/CONTRIBUTING.md#high-traffic-accounts) against the staging or production API to ensure
        there are no regressions (e.g. long loading states that impact usability).
    • I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/
      contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
    • I ran the tests on all platforms & verified they passed on:
      • Android: Native
      • Android: mWeb Chrome
      • iOS: Native
      • iOS: mWeb Safari
      • MacOS: Chrome / Safari
    • I verified there are no console errors (if there's a console error not related to the PR, report it or
      open an issue for it to be fixed)
    • I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/
      contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
      • I verified that comments were added to code that is not self explanatory
      • I verified that any new or modified comments were clear, correct English, and explained "why" the code
        was doing something instead of only explaining "what" the code was doing.
      • I verified any copy / text that was added to the app is grammatically correct in English. It adheres
        to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and
        is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval,
        ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
    • I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/
      contributingGuides/PR_REVIEW_GUIDELINES.md)
    • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or
      component like Avatar, I verified the components using Avatar are working as expected)
    • If a new CSS style is added I verified that:
      • A similar style doesn't already exist
      • The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/
        src/styles/utils/index.ts) function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
    • If new assets were added or existing ones were modified, I verified that:
      • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
      • The assets load correctly across all supported platforms.
    • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no
      unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold,
      strikethrough, and italic.
    • If the PR modifies a generic component, I tested and verified that those changes do not break usages of
      that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I
      verified that Avatar is working as expected in all cases)
    • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all
      stories for that component are still working as expected.
    • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code
      functions as expected when the deeplink is used - from a logged in and logged out account.
    • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing,
      moving components, etc) or modifies the form input styles:
      • I verified that all the inputs inside a form are aligned with each other.
      • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
    • I added unit tests for any new feature or
      bug fix in this PR to help automatically prevent regressions in this user flow.
    • If the main branch was merged into this PR after a review, I tested again and verified the outcome was
      still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
grok.mcp.connector.mp4

@rushatgabhane
rushatgabhane requested review from a team as code owners September 16, 2026 08:53
@melvin-bot
melvin-bot Bot requested review from Ollyws and trjExpensify and removed request for a team September 16, 2026 08:53
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 16, 2026 08:53
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T09:16:35.676982Z f7dc179 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 95.93% <100.00%> (+0.03%) ⬆️
src/components/CategoryPicker/index.tsx 97.91% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts 0.00% <ø> (ø)
src/components/ImageWithLoading.tsx 93.47% <100.00%> (ø)
...SearchList/ListItem/WithdrawalIDListItemHeader.tsx 97.10% <100.00%> (ø)
src/libs/TransactionUtils/index.ts 95.52% <100.00%> (ø)
...rt/ReportActionCompose/ComposerWithSuggestions.tsx 67.09% <100.00%> (-0.09%) ⬇️
src/pages/workspace/mcp/WorkspaceMCPPage.tsx 0.00% <0.00%> (ø)
...Navigation/AppNavigator/AuthScreensInitHandler.tsx 86.53% <57.14%> (-2.36%) ⬇️
...omponents/TextInput/TextInputMeasurement/index.tsx 47.05% <37.50%> (ø)
... and 9 files with indirect coverage changes

@rushatgabhane
rushatgabhane marked this pull request as draft September 16, 2026 09:58
@trjExpensify

Copy link
Copy Markdown
Contributor

What's the deal here, when's it coming out of review?

@trjExpensify

Copy link
Copy Markdown
Contributor

Bump, @rushatgabhane.

@rushatgabhane
rushatgabhane marked this pull request as ready for review September 28, 2026 09:40
@rushatgabhane

rushatgabhane commented Sep 28, 2026 •

Copy link
Copy Markdown
Member Author

@trjExpensify the MCP connector isn't live - https://github.com/Expensify/Expensify/issues/678279#issuecomment-5787192103. So we can't merge this yet

@trjExpensify

Copy link
Copy Markdown
Contributor

Okay, so the best practice is to cite that in the title with a hold. I've updated it.

@trjExpensify trjExpensify changed the title Add grokmcp connector [Hold E/E #678279] Add grokmcp connector Sep 28, 2026
# Conflicts:
#	src/components/Icon/chunks/expensify-icons.chunk.ts
@rushatgabhane

Copy link
Copy Markdown
Member Author

plugin not available yet

image

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants