Repository navigation
[Hold E/E #678279] Add grokmcp connector - #101307
rushatgabhane wants to merge 7 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
What's the deal here, when's it coming out of review? |
|
Bump, @rushatgabhane. |
|
@trjExpensify the MCP connector isn't live - https://github.com/Expensify/Expensify/issues/678279#issuecomment-5787192103. So we can't merge this yet |
|
Okay, so the best practice is to cite that in the title with a hold. I've updated it. |
# Conflicts: # src/components/Icon/chunks/expensify-icons.chunk.ts

Explanation of Change
Add Grok as the fourth connector on the Workspace → MCP page in NewDot. This includes the Grok icon, localized copy, and link to the Grok MCP setup guide.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/681777
PROPOSAL:
Tests
Offline tests
No offline testing performed.
QA Steps
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionthe entered data is not correct)
behavior (i.e. verify the default avatar icon is displayed if app is offline)
contributingGuides/CONTRIBUTING.md#high-traffic-accounts) against the staging or production API to ensure
there are no regressions (e.g. long loading states that impact usability).
contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
open an issue for it to be fixed)
contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
was doing something instead of only explaining "what" the code was doing.
to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and
is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval,
ask the Bug Zero team member to add the Waiting for copy label to the issue)
contributingGuides/PR_REVIEW_GUIDELINES.md)
component like
Avatar, I verified the components usingAvatarare working as expected)src/styles/utils/index.ts) function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold,
strikethrough, and italic.
that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, Iverified that
Avataris working as expected in all cases)stories for that component are still working as expected.
functions as expected when the deeplink is used - from a logged in and logged out account.
moving components, etc) or modifies the form input styles:
Designlabel and/or tagged@Expensify/designso the design team can review the changes.bug fix in this PR to help automatically prevent regressions in this user flow.
mainbranch was merged into this PR after a review, I tested again and verified the outcome wasstill expected according to the
Teststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
grok.mcp.connector.mp4