[Payment due @mkhutornyi] Add ask Concierge screen by rushatgabhane · Pull Request #100552 · Expensify/App

rushatgabhane · 2026-09-07T19:30:47Z

Explanation of Change

Builds the Ask Concierge screen from the Figma design in the main Concierge DM: a centered welcome empty state, a chat history toggle that expands and collapses the earlier conversation, and a Your personal AI assistant subtitle plus a New chat button in question threads. It also removes the conciergeRespondInThread beta, so Concierge answers every question from the main DM in its own thread, including a message with several attachments. This needs https://github.com/Expensify/Web-Expensify/pull/57207 deployed first.

Fixed Issues

For #94503
PROPOSAL:

Tests

Open the Concierge chat from the Inbox.
Verify the header reads Concierge with the subtitle Your personal AI assistant, and the composer placeholder is How much did I spend last month?.
Verify the chat shows the Concierge bot illustration, Ask me anything!, and the supporting copy. On a wide screen, verify the welcome and the composer are centered together. On a small screen (mobile), verify the welcome is centered above a composer docked at the bottom.
Press View chat history, verify the earlier conversation appears with Ask a new question above the composer, then press Hide chat history and verify it collapses again.
Ask a question, open the thread, and verify the header shows a New chat button that returns you to the Concierge chat in its welcome state.
In the Concierge chat, click + > Add attachment, pick two images, type What are these? and send. Verify one message shows both images, a thread opens off it, Concierge replies once in the thread.
Sign up a new account and pick Track expenses for my business in onboarding. Open the Concierge chat from the Inbox and verify it shows Ask me anything! with View chat history. Press View chat history and verify the onboarding tasks appear.

Verify that no errors appear in the JS console

Offline tests

Same as tests. The welcome state and the history toggle both read data already in Onyx, so they render offline; only expanding history beyond the cached page needs a connection.

QA Steps

Preconditions: three test accounts:

an account that has messaged Concierge before
a brand-new account with no onboarding tasks, so the Concierge chat is empty
a brand-new account with onboarding tasks

Welcome screen
1. Open Inbox > Concierge.
2. Verify the header shows Concierge with the subtitle Your personal AI assistant.
3. Verify the chat shows the Concierge illustration, Ask me anything!, Concierge can answer questions, update expenses, and more. and a View chat history button.
4. On a wide screen, verify the welcome and the composer are centered together. On mobile, verify the composer is docked at the bottom.
History toggle
1. Press View chat history. Verify the earlier conversation appears, Hide chat history shows, and Ask a new question appears above the composer.
2. Press Hide chat history. Verify the chat returns to the welcome screen.
Question opens a thread
1. From the welcome screen, type a question and send it.
2. Verify the app opens a new thread, Concierge replies there, and the header shows a New chat button.
3. Press New chat. Verify you land on the Concierge chat in its welcome state.
Several attachments
1. In the Concierge chat, press + > Add attachment and pick two images. Type What are these? and send.
2. Verify one message shows both images, a thread opens, and Concierge replies once in that thread.
Task
1. In the Concierge chat, send [] Buy milk.
2. Verify the task appears, the history is expanded, and the button reads Hide chat history.
New account
1. Sign up with a new account and finish onboarding.
2. Open Concierge and refresh.
3. Verify the welcome screen shows with View chat history.
4. Press View chat history. Verify the onboarding message and tasks are there.
Unread message
1. In the expanded history, hover a Concierge message and choose Mark as unread.
2. Leave the chat, then open Concierge again.
3. Verify the history is expanded and the message is visible, not hidden behind the welcome.
Link to a message
1. Open a link to a specific Concierge message, for example from a thread's parent link or a Search result.
2. Verify the chat opens at that message with Hide chat history, not the welcome screen.
Full-size composer
1. With the history expanded, expand the composer to full size.
2. Verify the composer's bottom border is fully visible.
3. Repeat from the welcome screen.
Another device
1. Keep the Concierge welcome open on web.
2. Send a question to Concierge from a phone signed in to the same account.
3. Verify the web stays on the welcome screen with no flash of the message list.
Offline
1. Go offline and send a question from the welcome screen. Verify the thread opens.
2. Go back to the Concierge chat. Verify it shows the welcome screen.
3. Go online. Verify it stays on the welcome screen.
Side panel and Search
1. Open the Concierge side panel from any report header. Verify it still shows its own greeting and, when there's earlier history, a Show history button.
2. Send a question in the side panel. Verify it switches to the new thread.
3. Open Search and use Ask Concierge to ask another question. Verify it creates a new thread instead of posting into the previous one.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-02.at.15.16.02.mov

Old stuff

Screen.Recording.2026-09-14.at.06.10.11.mov

melvin-bot · 2026-09-07T19:30:52Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-09-07T20:07:41Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/CONST/index.ts	`95.90% <ø> (ø)`
...components/Search/SearchRouter/useAskConcierge.tsx	`96.96% <100.00%> (+0.19%)`	⬆️
src/hooks/useConciergeAskState.ts	`100.00% <100.00%> (ø)`
src/hooks/useIsAskConciergeChat.ts	`100.00% <100.00%> (ø)`
src/hooks/useReportActionsListModel.ts	`100.00% <100.00%> (ø)`
src/hooks/useReportActionsVisibility.ts	`93.93% <100.00%> (-0.51%)`	⬇️
src/hooks/useShouldSuppressConciergeIndicators.tsx	`100.00% <100.00%> (ø)`
src/libs/ReportUtils.ts	`90.03% <100.00%> (+0.05%)`	⬆️
src/libs/actions/Report/index.ts	`75.15% <100.00%> (+0.74%)`	⬆️
... and 19 more
... and 8 files with indirect coverage changes

This reverts commit 6a5df9b.

This reverts commit eca32a2.

rushatgabhane · 2026-09-14T03:14:49Z

@mkhutornyi next PR that you can start reviewing

This reverts commit c278aec.

rushatgabhane · 2026-10-23T10:38:02Z

@mkhutornyi all yours

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/Report/index.ts # src/libs/actions/RequestConflictUtils.ts # tests/unit/RequestConflictUtilsTest.ts

…erge-ask-design

mkhutornyi · 2026-10-25T14:12:54Z

Bug: after login, no concierge welcome screen until refresh. Legacy page shows

Screen.Recording.2026-10-20.at.11.00.14.AM.mov

This is still happening. Even worse than before ("Hide chat history" button doesn't appear)

Screen.Recording.2026-10-25.at.2.10.11.PM.mov

rushatgabhane · 2026-10-25T14:32:50Z

This is still happening. Even worse than before ("Hide chat history" button doesn't appear)

looking

rushatgabhane · 2026-10-25T15:10:13Z

@mkhutornyi fixed

rushatgabhane · 2026-10-25T15:22:25Z

This is still happening. Even worse than before ("Hide chat history" button doesn't appear)

Fixed. New accounts now get Ask me anything! with View chat history.
Always. Even when onboarding tasks are present.

mkhutornyi · 2026-10-25T15:56:34Z

Screen.Recording.2026-10-25.at.3.46.25.PM.mov

For new account with onboarding tasks, the behavior is inconsistent between:

side panel from Help button (not welcome screen, neither "View chat history" nor "Hide chat history")
opened from deep link (welcome screen, "View chat history" shows)

mkhutornyi

I've completed review.
I am suggesting detailed test steps below for QA team to test. Please review and update QA Steps section accordingly.

melvin-bot · 2026-10-25T16:00:35Z

🎯 @mkhutornyi, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

mkhutornyi · 2026-10-25T16:02:39Z

QA Steps

Preconditions: 3 types of test accounts:

an account that has messaged Concierge before
brand-new account with no onboarding tasks so concierge chat is completely empty
brand-new account with onboarding tasks.

Welcome screen
1. Open Inbox → Concierge.
2. Verify the header shows Concierge with the subtitle Your personal AI assistant.
3. Verify the chat shows the Concierge illustration, Ask me anything!, Concierge can answer questions, update expenses, and more. and a View chat history button.
4. On a wide screen, verify the welcome and the composer are centered together. On mobile, verify the composer is docked at the bottom.
History toggle
1. Press View chat history. Verify the earlier conversation appears, Hide chat history shows, and Ask a new question appears above the composer.
2. Press Hide chat history. Verify the chat returns to the welcome screen.
Question opens a thread
1. From the welcome screen, type a question and send it.
2. Verify the app opens a new thread, Concierge replies there, and the header shows a New chat button.
3. Press New chat. Verify you land on the Concierge chat in its welcome state.
Several attachments
1. In the Concierge chat, press + → Add attachment and pick two images. Type What are these? and send.
2. Verify one message shows both images, a thread opens, and Concierge replies once in that thread.
Task
1. In the Concierge chat, send [] Buy milk.
2. Verify the task appears, the history is expanded, and the button reads Hide chat history.
New account
1. Sign up with a new account and finish onboarding.
2. Open Concierge and refresh.
3. Verify the welcome screen shows with View chat history.
4. Press View chat history. Verify the onboarding message and tasks are there.
Unread message
1. In the expanded history, hover a Concierge message and choose Mark as unread.
2. Leave the chat, then open Concierge again.
3. Verify the history is expanded and the message is visible, not hidden behind the welcome.
Link to a message
1. Open a link to a specific Concierge message, for example from a thread's parent link or a Search result.
2. Verify the chat opens at that message with Hide chat history, not the welcome screen.
Full-size composer
1. With the history expanded, expand the composer to full size.
2. Verify the composer's bottom border is fully visible.
3. Repeat from the welcome screen.
Another device
1. Keep the Concierge welcome open on web.
2. Send a question to Concierge from a phone signed in to the same account.
3. Verify the web stays on the welcome screen with no flash of the message list.
Offline
1. Go offline and send a question from the welcome screen. Verify the thread opens.
2. Go back to the Concierge chat. Verify it shows the welcome screen.
3. Go online. Verify it stays on the welcome screen.
Side panel and Search
1. Open the Concierge side panel from any report header. Verify it still shows its own greeting and, when there's earlier history, a Show history button.
2. Send a question in the side panel. Verify it switches to the new thread.
3. Open Search and use Ask Concierge to ask another question. Verify it creates a new thread instead of posting into the previous one.

rushatgabhane · 2026-10-25T16:03:23Z

For new account with onboarding tasks, the behavior is inconsistent between:

side panel from Help button

The side panel is out of scope for this PR. It works the same as production, and this PR only changes the main Concierge chat.

rushatgabhane · 2026-10-25T16:05:37Z

thanks for the qa steps @mkhutornyi

rushatgabhane · 2026-10-25T16:17:17Z

hey @puneetlath can you please trigger web and mobile build for this PR? we want to send this to QA before merging

Ask Concierge design

cdea881

melvin-bot Bot assigned rushatgabhane Sep 7, 2026

Fix CI failures

f6bb415

rushatgabhane added 19 commits September 13, 2026 22:50

Merge main

40ce940

Fix Button import

60fe442

Remove quick actions

95be964

Center welcome layout

a666030

Responsive column width

7329000

Remove top margin

8260e1f

Rotate placeholder

dbbb733

Reuse existing placeholders

82a7efd

Remove list padding

47eb7f4

Fix history toggle

43392ff

Fix title line height

05f6511

Own welcome typography

b44fa4c

Always show toggle

25df82d

Space welcome divider

405db86

Fix session race

6a5df9b

Add placeholder rotation

ea11c45

Revert "Fix session race"

eca32a2

This reverts commit 6a5df9b.

Reapply "Fix session race"

f68bab5

This reverts commit eca32a2.

Fix CI checks

c5c9975

rushatgabhane added 5 commits September 14, 2026 05:16

Drop CSV placeholder

c278aec

Revert "Drop CSV placeholder"

134ddab

This reverts commit c278aec.

Fix history toggle

0f7309a

Drop comment

75caf8d

Welcome instead of skeleton

3e8dfe7

rushatgabhane added 2 commits October 22, 2026 01:23

Simplify same-name attachment matching

88c74a8

Merge branch 'Expensify:main' into concierge-ask-design

068fe8d

rushatgabhane added 6 commits October 23, 2026 13:39

Merge branch 'Expensify:main' into concierge-ask-design

9213648

Merge remote-tracking branch 'upstream/main' into concierge-ask-design

9e3c4f0

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/Report/index.ts # src/libs/actions/RequestConflictUtils.ts # tests/unit/RequestConflictUtilsTest.ts

Merge remote-tracking branch 'origin/concierge-ask-design' into conci…

01977a5

…erge-ask-design

Stop exporting getUploadingAttachmentSource

937131d

Use the shared readFileAsync mock in the multi-attachment payload test

d268b20

Key renamed attachment labels by a named attachment ID in tests

6951094

mkhutornyi reviewed Oct 25, 2026

View reviewed changes

Comment thread src/CONST/index.ts

rushatgabhane requested a review from mkhutornyi October 25, 2026 14:30

rushatgabhane added 3 commits October 25, 2026 15:48

Show the Concierge welcome to users who never messaged Concierge

80afd0a

Fold the Concierge welcome tests into one case

ff1edce

Merge remote-tracking branch 'upstream/main' into concierge-ask-design

529ef45

mkhutornyi reviewed Oct 25, 2026

View reviewed changes

Comment thread src/hooks/useReportActionsVisibility.ts Outdated

Comment thread src/hooks/useReportActionsListModel.ts Outdated

Comment thread src/libs/actions/Report/index.ts

Comment thread src/hooks/useConciergeAskState.ts Outdated

Comment thread src/pages/inbox/HeaderView.tsx Outdated

Address Ask Concierge review comments

779dd28

mkhutornyi approved these changes Oct 25, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Add ask Concierge screen~~ [Payment due @mkhutornyi] Add ask Concierge screen Oct 25, 2026

rushatgabhane requested a review from puneetlath October 25, 2026 16:04

rushatgabhane added the Ready To Build label Oct 25, 2026

Conversation

rushatgabhane commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Old stuff

Uh oh!

melvin-bot Bot commented Sep 7, 2026

Uh oh!

codecov Bot commented Sep 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rushatgabhane commented Sep 14, 2026

Uh oh!

rushatgabhane commented Oct 23, 2026

Uh oh!

mkhutornyi commented Oct 25, 2026

Uh oh!

Uh oh!

rushatgabhane commented Oct 25, 2026

Uh oh!

rushatgabhane commented Oct 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rushatgabhane commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhutornyi commented Oct 25, 2026

Uh oh!

mkhutornyi left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 25, 2026

Uh oh!

mkhutornyi commented Oct 25, 2026

QA Steps

Uh oh!

rushatgabhane commented Oct 25, 2026

Uh oh!

rushatgabhane commented Oct 25, 2026

Uh oh!

rushatgabhane commented Oct 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rushatgabhane commented Sep 7, 2026 •

edited

Loading

codecov Bot commented Sep 7, 2026 •

edited by github-actions Bot

Loading

rushatgabhane commented Oct 25, 2026 •

edited

Loading