Skip to content

[Due for payment 2026-11-05] Payment issue for E/App PR#104566 #105416

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #104566
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/685831.
Contributor+ member who reviewed the PR - @ikevin127.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    Author

    @ikevin127 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Nov 4, 2026

    @melvin-bot
    Author

    @ikevin127 Huh... This is 4 days overdue. Who can take care of this?

  3. melvin-bot commented on Nov 4, 2026

    @melvin-bot
    Author

    @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

  4. ikevin127 commented on Nov 4, 2026

    @ikevin127
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A - This PR adds a new feature (the Rejected column in Search), so there is no regression and no offending PR.
      Link to the comment on the Issue: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. As a submitter on a workspace with approvals enabled, submit three reports to an approver.
    2. As the approver, reject one expense on the first report.
    3. As the approver, reject the whole second report.
    4. As the submitter, go to Spend > Expenses.
    5. Click Display > Edit columns.
    6. Verify that Rejected is listed and not selected by default.
    7. Select Rejected and click Save.
    8. Verify that the Rejected column shows Yes for the rejected expense and No for the others.
    9. Click the Rejected column header.
    10. Verify that the rejected expense moves to the top.
    11. Click the Rejected column header again.
    12. Verify that the rejected expense moves to the bottom.
    13. Select all expenses and click Export > Current view.
    14. Verify that the exported file has a Rejected column with Yes for the rejected expense and No for the others.
    15. Go to Spend > Reports and repeat steps 5 to 14.
    16. Verify that the Rejected column, sorting and export show Yes for the second report and No for the first and third reports.

    Do we agree 👍 or 👎.

  5. melvin-bot commented on Nov 4, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Nov 4, 2026

    @melvin-bot
    Author

    @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

  7. melvin-bot commented on Nov 4, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. mallenexpensify commented on Nov 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ikevin127 due $175 via NewDot

  9. quinthar commented on Nov 8, 2026

    @quinthar
    Contributor

    Approved $175 to @ikevin127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions