Skip to content

[Due for payment 2026-11-05] Payment issue for E/App PR#100590 #105313

Open

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #100590
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/633485.
Contributor+ member who reviewed the PR - @daledah.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    Author

    @daledah The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. daledah commented on Oct 29, 2026

    @daledah
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Open the app.
    2. Go to app switcher and verify the card is covered by bootspash or it's version without the logo (on Android). Same after going Home first.
    3. Return to the app and verify the content is restored and the app is interactive.
    4. With the keyboard open, background the app and verify the switcher card shows no content or keyboard.
    5. In the foreground, take a regular screenshot and verify it still captures the content.
    6. Android: open an in-app dialog and verify the splash doesn't cover the app.
    7. Android: start the Plaid bank connection flow (Workspace > More features > enable Workflows > navigate back > Workflows > Add bank account), background the app during the bank login screen and verify the app switcher card is the plain green one with no bank UI content. Going Home or switching to another app first and then opening recents shows the plain green card, while swiping straight from Plaid into recents shows the live Plaid screen on its card.

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions