Repository navigation
[Due for payment 2026-11-02] Vendor - 0 selected button is not shown in selection mode after deselecting vendor #104908
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103549
Email or phone of affected tester (no customers): sjodinjoisdjoisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 17 Pro Max / iOS 27.0.1
App Component: Workspace Settings
Action Performed:
Precondition:
- Connect to Sage Intacct.
- Launch Expensify app.
- Go to workspace settings > Categories.
- Long tap on any category > Select.
- Deselect the category.
→ 0 selected button is shown. - Go to workspace settings > Vendors.
- Long tap on any vendor > Select.
- Deselect the vendor.
Expected Result:
0 selected button will be shown in selection mode after deselecting vendor.
Actual Result:
0 selected button is not shown in selection mode after deselecting vendor.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7294650_1792778615437.ScreenRecording_10-24-2026_01-58-57_1.mp4
Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7294650
Issue Owner
Current Issue Owner: @Pujan92Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/499cc7d1b133350b0160d73fdbeb6907111995ad4721f71363bfa4fba93dc624
melvin-bot commentedon Oct 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103549
melvin-bot commentedon Oct 23, 2026
@Beamanator @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 23, 2026
Deploy Blocker Analysis
Causing PR: Add imported vendor enable and disable controls. I'm highly confident. This is a frontend bug.
Root cause: The new Vendors selection mode hides the bulk-action button whenever 0 vendors are selected. Two separate checks cause this, and each one hides the button by itself:
WorkspaceVendorsPage.tsx:219setscanShowBulkActions = canWriteVendors && selectedVendorKeys.length > 0. It ignores whether mobile selection mode is on.WorkspaceVendorsPage.tsx:98-100:VendorBulkActionsreturnsnullwhen it has no options, and it has none when nothing is selected. Because of this early return, theisDisabled={!selectedVendorKeys.length}check at L112 never applies.Categories works differently. On small screens it shows the button whenever selection mode is on (
isSmallScreenWidth ? canSelectMultiple : selectedCategoryKeys.length > 0), and it renders the button even when the options list is empty. That gives a disabled "0 selected" button.Recommendation: fix forward instead of reverting. Reverting would remove the whole feature over a cosmetic difference. The PR changes 30 files, comes with paired backend changes, and is already a re-apply of a reverted PR. Also, the page sits behind the Vendor Matching beta. If no fix lands in time, demoting this issue is reasonable.
Suggested fix (
WorkspaceVendorsPage.tsx):Then delete the
if (options.length === 0) { return null; }early return inVendorBulkActions. With 0 selected, the existingisDisabledandshouldAlwaysShowDropdownMenuprops then render a disabled "0 selected" button.Side effect of the fix
The enabled default vendor can't be disabled. If it's the only selected vendor, the button will now show "1 selected" with an empty dropdown instead of hiding. Categories does the same when an accounting connection exists. To keep hiding the button in that case, use
if (options.length === 0 && selectedVendorKeys.length > 0) return null;instead.view run
2 remaining items
Beamanator commentedon Oct 26, 2026
PR merged, CPing
Beamanator commentedon Oct 26, 2026
looking good in staging! see #104898 (comment)
Beamanator commentedon Oct 26, 2026
will leave open to make sure it gets to prod & no regression & payment works out
[-]Vendor - 0 selected button is not shown in selection mode after deselecting vendor[/-][+][Due for payment 2026-11-02] Vendor - 0 selected button is not shown in selection mode after deselecting vendor[/+]melvin-bot commentedon Oct 26, 2026
@Pujan92
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 29, 2026
@Pujan92 Whoops! This issue is 2 days overdue. Let's get this updated quick!