Repository navigation
Vendors - Changelog shows code instead of vendor name in #admins room #104894
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103549
Email or phone of affected tester (no customers): sjodinjoisdjoisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
- Connect to Sage Intacct.
- Go to staging.new.expensify.com
- Go to workspace settings > Vendors.
- Disable any vendor.
- Go to #admins.
Expected Result:
Changelog will show vendor name.
Actual Result:
Changelog shows code.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7294613_1792776163628.4.mp4
Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7294613
Issue Owner
Current Issue Owner: @ShridharGoelMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d3f24b0d99d39690ce51d0c35e6949a48d14bc7dfa49337dee8b9a9084c612d1
melvin-bot commentedon Oct 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103549
melvin-bot commentedon Oct 23, 2026
@Beamanator @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 23, 2026
Deploy Blocker Analysis
Causing PR: Add imported vendor enable and disable controls. It added the vendor enable/disable feature that shows this bug.
Root cause: The server writes the #admins changelog text, and it uses the vendor IDs it receives instead of the vendor names. App sends only the vendor codes (
externalID) and displays the server's message as-is. App never builds this message.Recommendation: roll forward with a backend fix. This appears to be a backend/internal issue. A separate internal investigation is needed. The server should look up each vendor's name before writing the changelog. No App change is needed. If the backend fix can't land quickly, consider demoting: the bug only affects changelog text, the feature is behind a beta, and enable/disable works. Reverting the App PR would remove the whole feature without fixing anything in App.
Evidence
src/libs/actions/Policy/Vendor.ts:71-100:setPolicyVendorsEnabledonly mergespolicyVendors_{policyID}. It creates no optimistic report action. It callsSetPolicyVendorsEnabledwith{policyID, vendorIDs, enabled}.src/libs/API/parameters/SetPolicyVendorsEnabledParams.ts:7: the API takesvendorIDs: stringand no names. The IDs come fromvendor.externalID, which is the Sage Intacct vendor code. The name is stored separately inPolicyVendor.name.src/pages/inbox/report/actionContents/ActionContentRouter.tsx:376: App has no vendor changelog type, soisHandledPolicyChangeLogActionreturns false. The action falls through toChatMessageContentat line 593, which renders the server'smessage.htmlas written.ReportActionsUtils,PolicyChangeLogContent, or the report action constants.Optional follow-up: if the server also put
vendorNameinoriginalMessage, App could add a translated changelog message, as it already does for tags and categories.view run
Beamanator commentedon Oct 23, 2026
hmm same i'd also probably not consider this a blocker, should be an easy fix - thoughts @heyjennahay ?
Beamanator commentedon Oct 23, 2026
discussing in internal slack thread - https://expensify.slack.com/archives/C07HPDRELLD/p1792788138867319?thread_ts=1792408332.000239&cid=C07HPDRELLD
Beamanator commentedon Oct 26, 2026
PR is backend ^ and this is a minor bug so demoting
Beamanator commentedon Oct 26, 2026
PR merged
melvin-bot commentedon Oct 29, 2026
@Beamanator, @Pujan92, @ShridharGoel Whoops! This issue is 2 days overdue. Let's get this updated quick!
Beamanator commentedon Oct 29, 2026
not sure if the fix is in prod yet?