Repository navigation
[Due for payment 2026-11-02] Expense- "Vendor no longer valid" error does not appear on Vendor field when disabled offline #104892
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103549
Email or phone of affected tester (no customers): sjodinjoisdjoisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
-Connect to Sage Intacct.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create a non-reimbursable expense.
- Open the expense.
- Click Vendor.
- Select any vendor.
- Go offline.
- Go to workspace settings > Vendors.
- Disable any vendor.
- Open the expense in Step 3.
Expected Result:
"Vendor no longer valid" error will appear on Vendor field when vendor is disabled offline (similar to disabling category in offline mode).
Actual Result:
"Vendor no longer valid" error does not appear on Vendor field when vendor is disabled offline.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7294614_1792776164167.5.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7294614
Issue Owner
Current Issue Owner: @Pujan92Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8b9f4b8ed4a3bf22bb0eb9cfa25502f6515365447491f192206e0a2842e12893
melvin-bot commentedon Oct 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103549
melvin-bot commentedon Oct 23, 2026
@Beamanator @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 23, 2026
Deploy Blocker Analysis
Causing PR: Add imported vendor enable and disable controls (high confidence). This is a gap in a new feature. Production isn't affected.
Root cause: Disabling a vendor updates only the vendor list. It never recalculates violations on existing expenses.
setPolicyVendorsEnabledwrites optimistic data only topolicyVendors_{policyID}. In contrast,setWorkspaceCategoryEnabledcallspushTransactionViolationsOnyxData. That call is why the category error appears offline. The Vendor field shows "Vendor no longer valid" only when anINACTIVE_VENDORviolation is stored. Offline, nothing creates one.Recommendation: demote and fix in a follow-up. Don't revert. The error is missing only while offline. No data is lost, and reverting would pull the whole enable/disable feature. First, someone should confirm the error appears after the device reconnects. If it's missing online too, the cause is on the server, so don't demote until that's checked.
Fix: Pass
policyDataandisVendorMatchingBetaEnabledfromWorkspaceVendorsPageintosetPolicyVendorsEnabled. Then push optimistic violation updates for expenses whosecomment.vendor.externalIDmatches a toggled vendor, with failure data that restores the old violations. ExtendingpushTransactionViolationsOnyxDatato accept updatedpolicyVendorswould do it. Re-enabling a vendor should clear the violation the same way.Investigation details
ViolationsUtils.ts:816-825already returnsINACTIVE_VENDORwhenpolicyVendors[id].enabled === false. That code runs only when someone edits an expense, not when an admin toggles a vendor.MoneyRequestView.tsx:578-583confirms the error text comes only from the stored violation.pushTransactionViolationsOnyxDatadoesn't passpolicyVendors, so category or tag changes made offline won't flag disabled vendors either. You could fix both together.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.6 remaining items
Beamanator commentedon Oct 26, 2026
looking good in staging! see #104898 (comment)
Beamanator commentedon Oct 26, 2026
will leave open to make sure it gets to prod & no regression & payment works out
[-]Expense- "Vendor no longer valid" error does not appear on Vendor field when disabled offline[/-][+][Due for payment 2026-11-02] Expense- "Vendor no longer valid" error does not appear on Vendor field when disabled offline[/+]melvin-bot commentedon Oct 26, 2026
@Pujan92
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 29, 2026
@Pujan92 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
IuliiaHerets commentedon Nov 1, 2026
Not repro on Windows 10/Chrome/Build v9.5.27-0
2026-11-01.11-30-09.mp4