Repository navigation
[Due for payment 2026-11-02] Rules - Disabled vendor is shown in vendor list when creating rule #104891
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103549
Email or phone of affected tester (no customers): sjodinjoisdjoisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
- Connect to Sage Intacct.
- Enable Rules.
- Go to staging.new.expensify.com
- Go to workspace settings > Vendors.
- Disable any vendor.
- Go to workspace settings > Rules.
- Click Add rule.
- Click Apply expense defaults > Merchant.
- Click Vendor.
Expected Result:
The disabled vendor will not appear in vendor list when creating rule (similar to disabled category and tag).
Actual Result:
The disabled vendor is shown in vendor list when creating rule (similar to disabled category and tag).
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7294615_1792776164819.6.1.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7294615
Issue Owner
Current Issue Owner: @Pujan92Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/96185fef512f3900f16b42a4aa05748b3369335f0223a1f1341b7cbe9a0fd481
melvin-bot commentedon Oct 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103549
melvin-bot commentedon Oct 23, 2026
@Beamanator @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #103549
melvin-bot commentedon Oct 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 23, 2026
Deploy Blocker Analysis
Cause: Add imported vendor enable and disable controls added a per-vendor
enabledflag. It updated the expense vendor picker to hide disabled vendors, but not the vendor picker in Rules. The Rules picker still lists every vendor from the accounting connection.Recommendation: Fix forward instead of reverting. The fix is a few lines. A revert would remove the whole vendor enable/disable feature.
Confidence: High. This is a gap in a new feature, not a regression. Production has no way to disable a vendor.
Investigation details
Where the list is built
AddVendorPage.tsx:34-37:getVendorSelectionItemsreturnsgetMatchingVendors(policy)with no filter. The page never readspolicyVendors_<policyID>, where theenabledflag lives.AddVendorPage.tsxis not in the PR's file list. The Rules vendor picker came from an earlier PR, [Payment due @abzokhattab] Add vendorID action field to merchant coding rules (vendor matching R5, Phase B). Vendors could not be disabled back then.How the other pickers handle it
IOURequestStepVendor.tsx:101filterspolicyVendorsbyenabled.AddCategoryPage.tsx:33filters byenabled.AddTagPage.tsx:49skips disabled tags, except the tag already on the rule.Same gap in CSV import
ImportedMerchantRulesPage.tsx:124-131:buildImportedVendorLookupmatches against all vendors. The category version at line 111 skips disabled categories. A CSV import can still put a disabled vendor on a rule.Suggested fix
AddVendorPage.tsx, readpolicyVendorswithuseOnyx(\${ONYXKEYS.COLLECTION.POLICY_VENDORS}${policyID}`)`.getVendorSelectionItems. Keep a vendor whenvendor.id === form?.vendorID || policyVendors?.[vendor.id]?.enabled !== false. This matchesAddTagPageand keeps the vendor already on the rule.openPolicyVendorsPage(policyID)whenpolicyVendorsis undefined, asIOURequestStepVendordoes.buildImportedVendorLookup.getVendorSelectionItems.This assumes the connection vendor
idmatches theexternalIDkey inpolicyVendors. The offending PR relies on the same assumption in its violation check.Next Steps:
ShridharGoel, you're assigned as the PR author. Please raise a follow-up fix. Reply with@MelvinBot implement thisif you'd like me to draft the PR.view run
Beamanator commentedon Oct 26, 2026
PR merged, CPing
Beamanator commentedon Oct 26, 2026
looking nice and fixed by #104895! WIll leave this open till it gets to prod & regression period is done
[-]Rules - Disabled vendor is shown in vendor list when creating rule[/-][+][Due for payment 2026-11-02] Rules - Disabled vendor is shown in vendor list when creating rule[/+]melvin-bot commentedon Oct 26, 2026
@Pujan92
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]