Skip to content

[Due for payment 2026-10-30] Payment issue for E/App PR#104076 #104873

Open

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #104076
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/691882.
Contributor+ member who reviewed the PR - @situchan.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 23, 2026

    @melvin-bot
    Author

    @situchan The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. situchan commented on Oct 24, 2026

    @situchan
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: new feature
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. As a member of a workspace, create three expenses on a report.
    2. Hold the first expense.
    3. Hold the second expense, then remove the hold.
    4. Go to Spend > Expenses and click Filters.
    5. Verify Held appears below Rejected.
    6. Select Held > Yes.
    7. Verify a "Held: Yes" chip appears and only the first expense is listed.
    8. Change the chip to No.
    9. Verify the second and third expenses are listed and the first is not.
    10. Go to Spend > Reports and click Filters.
    11. Verify Held is not offered.
    12. Click the search icon and type held:.
    13. Verify the suggestions are held:no and held:yes.
    14. Search for type:expense -held:yes after clicking on the Search magnifying glass icon.
    15. Verify the first expense is not listed.

    Do we agree 👍 or 👎

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 24, 2026
  4. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions