Repository navigation
Integration- Unable to upgrade Netsuite connection #104687
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103927
Email or phone of affected tester (no customers): duytestnguyen+dk49@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 Chrome
App Component: Workspace Settings
Action Performed:
Preconditions:
- Have one or more connections connected to the NetSuite accounting integration over SOAP TBA.
- Open https://staging.new.expensify.com/
- Navigate to Home
- Navigate to Workspace settings
- Click on Accounting
Expected Result:
At Home, Verify that a time-sensitive item corresponding to each workspace connected to NetSuite over SOAP TBA is displayed.
Verify that there is a notice below the Last synced notice asking to upgrade the NetSuite connection.
Actual Result:
There is no option to upgrade Netsuite connection in Accounting and there is no time-sensitive item corresponding to each workspace connected to NetSuite over SOAP TBA is displayed.
reproduce in both Gmail and Expensifail accounts.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7292854_1792646303847.103927W.mp4
Applause Internal Information
Exported by: Rizky Gunawan
Bug ID: 7292854
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8b7dc04ff07a4ece9b8632dd94256b3d225918cc4ff0502525e4f1f375e3c81e
melvin-bot commentedon Oct 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103927
melvin-bot commentedon Oct 22, 2026
@francoisl @yuwenmemon you have been assigned to this deploy blocker because you reviewed the offending PR: #103927
github-actions commentedon Oct 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 22, 2026
@akinwale you have been assigned to this deploy blocker because you authored the offending PR: #103927
melvin-bot commentedon Oct 22, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 22, 2026
Deploy Blocker Analysis
Recommendation: Demote, don't revert. Add NetSuite OAuth migration nudges is most likely working as designed. During review, the PR was changed to show the nudge only for workspaces with a simple NetSuite sync configuration. The QA steps were never updated to include that precondition, so a typical SOAP TBA test connection correctly shows nothing.
Next step: Ask QA to retest with a NetSuite TBA connection where all of these are true:
If the nudge appears, close this issue. If it still doesn't appear, check whether the tester's policy data includes
connections.netsuite.tokenSecretandoptions.config.syncOptions. If either is missing, the cause is a backend data dependency, not this App PR.Confidence: medium. I couldn't inspect the tester's account data.
Investigation details
Both the Home time-sensitive item and the Accounting notice use
shouldShowNetSuiteOAuthMigrationNudge(utils.ts:114-142). It returnstrueonly when all of these hold:verified === false, andauthTypeisn'toauth2.accountID,tokenID, andtokenSecretare all set.hasSimpleNetSuiteSyncConfigurationis true (utils.ts:101-112).syncOptionsmust exist, andsyncTax,syncReimbursedReports,syncCustomSegments, andsyncCustomListsmust be off, with no custom segments or lists.accountIDhas a non-simple configuration (utils.ts:129-141).Conditions 3 and 4 came from review commits
0e35c05a("limit OAuth migration nudges") and10198c89("account for shared connections"). The PR's Tests and QA steps still list only "connected to NetSuite over SOAP TBA" as the prerequisite.Other checks:
useTimeSensitiveNetSuiteMigration.ts).canWriteAccounting. A QuickBooks Online expiry hint takes priority if present (PolicyAccountingPage.tsx).Why not revert: This is a new feature that isn't in production yet. The PR adds a nudge and changes no existing behavior.
Follow-up for the PR author: Add the simple-configuration precondition to the PR's QA steps.
Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.view run
yuwenmemon commentedon Oct 22, 2026
@akinwale I would imagine we should still show the upgrade option, even if we're not showing the banner.
melvin-bot commentedon Oct 23, 2026
@francoisl / @yuwenmemon @akinwale
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 26, 2026
@francoisl, @akinwale, @yuwenmemon Whoops! This issue is 2 days overdue. Let's get this updated quick!
francoisl commentedon Oct 26, 2026
PR #104777 is on production. I believe there's no one-off payments due for this issue, but let me know if I'm wrong!