Web-Workspace- Press ESC select all checkbox is highlighted

@Krishna2323

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102380
Email or phone of affected tester (no customers): duytestnguyen+dk49@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 Chrome
App Component: Workspace Settings

Action Performed:

Preconditions:

Add some member to workspace

Open https://staging.new.expensify.com/
Navigate to Workspace settings
Click on Members
Click on 'select all' checkbox
Press 'Esc' on keyboard

Expected Result:

The checkbox is unchecked without any highlight

Actual Result:

The checkbox is highlighted at border

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7292664_1792622871916.bandicam_2026-10-22_05-41-16-281.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Rizky Gunawan
Bug ID: 7292664

Issue Owner

Current Issue Owner: @Krishna2323

You have been assigned to this deploy blocker because you recently merged this PR: #102380

@JS00001

@JS00001 @shubham1206agra you have been assigned to this deploy blocker because you reviewed the offending PR: #102380

@Krishna2323

@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #102380

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

💬 A slack conversation has been started in #expensify-open-source

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/77f196aaa703192c45a6eadcbc6331ae1e914f615a793668574b10f369f700d0

Deploy Blocker Investigation

Causing PR (high confidence): Offer the workspace members bulk actions in the floating bar. It added the bulk action bar to Members, including the Esc handler that's meant to hide this focus ring. Test steps 22–23 in that PR cover this exact case, and they fail.

Recommendation: demote, then fix forward. The bug is cosmetic: Esc still clears the selection, and only a 1px focus ring is left. Reverting a 53-file feature for that isn't worth it.

Root cause: useBulkActionBarFocus/index.ts:146-148 skips the suppression when the checkbox already matches :focus-visible. Pressing Esc is what makes it match, so the check always returns early. markProgrammaticFocus never runs, and the focus-ring CSS draws the ring.

Fix: Replace isShowingFocusRing(active) with getHadTabNavigation() from src/libs/hadTabNavigation.ts. Esc doesn't change that flag. Mouse users lose the ring, and keyboard users who tabbed to the checkbox keep it. Add a unit test for suppressStrayFocusRing.

Investigation details

The Esc shortcut in BulkActionBar/index.tsx:118-129 calls suppressStrayFocusRing() and then onClearSelection().
isShowingFocusRing only runs element.matches(':focus-visible'). The code comment at line 144 says Esc makes the focused element match :focus-visible. By the time the handler runs, the mouse-clicked checkbox already matches, so the guard defeats itself.
hadTabNavigation is set to true only by Tab. Pointer and mouse down set it to false, and Esc isn't counted as a typing key. restoreFocusWithModality already uses this flag.
Other PRs ruled out: None of the 57 App PRs in Deploy Checklist: New Expensify 2026-10-21 touch the focus-ring CSS, the Esc shortcut, the header checkbox, or this hook.
New to this release: Production has no bulk bar on Members, so Esc there leaves the workspace. That matches "N/A in production". The expense report view's bulk bar may show the same ring in production. That's unverified.
No test coverage: tests/unit/useBulkActionBarFocusTest.ts never calls suppressStrayFocusRing.
Not verified: The exact Chrome timing comes from the code comment and the QA result. I didn't reproduce it in a browser.

Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

view run

@Krishna2323

Demoting, @Krishna2323 lets fix this though

I'll have a PR up for this today.

ty!

Keep the focus ring off a checkbox the selection was made with by mouse

This issue is covered in #105229

Navigation Menu

Repository navigation

Web-Workspace- Press ESC select all checkbox is highlighted #104680

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Deploy Blocker Investigation

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Web-Workspace- Press ESC select all checkbox is highlighted #104680

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 22, 2026

melvin-bot commented on Oct 22, 2026

melvin-bot commented on Oct 22, 2026

github-actions commented on Oct 22, 2026

melvin-bot commented on Oct 22, 2026

applause-bot commented on Oct 22, 2026

MelvinBot commented on Oct 22, 2026

Deploy Blocker Investigation

JS00001 commented on Oct 22, 2026

Krishna2323 commented on Oct 26, 2026

JS00001 commented on Oct 26, 2026

Krishna2323 commented on Oct 28, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions