Skip to content

Members - Change role RHP disappears after refreshing the page #104644

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102380
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Invite another member to the workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Bulk select any member.
  4. Click Change role.
  5. Refresh the page.

Expected Result:

Change role RHP will remain opened after refreshing the page.

Actual Result:

Change role RHP disappears after refreshing the page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7292512_1792612439635.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7292512

Activity

  1. applause-bot commented on Oct 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/3c6d4a2e184cd4509f10bf447381f9f22a64f046cf071f25bc92e2330faf30b3

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2026
  3. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102380

  4. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @JS00001 @shubham1206agra you have been assigned to this deploy blocker because you reviewed the offending PR: #102380

  5. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #102380

  6. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Oct 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Oct 21, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Recommendation: demote. This isn't a blocker. Offer the workspace members bulk actions in the floating bar caused it, but the RHP closing on refresh is intentional. No revert or fix is needed for this deploy.

    Why it closes: The bulk selection is stored only in memory. After a refresh the selection is empty, so the page sends you back to the Members page. This stops a role from being applied to members who are no longer selected. The redirect is at WorkspaceMembersRolePage.tsx:68-76.

    Investigation details
    • New screen: WorkspaceMembersRolePage.tsx doesn't exist at production tag 9.5.15-3. The PR merged on 2026-10-21 and is in the current staging deploy.
    • Memory-only key: The page reads RAM_ONLY_WORKSPACE_MEMBERS_SELECTED_FOR_ROLE_CHANGE at WorkspaceMembersRolePage.tsx:40. The key is registered as memory-only at setup/index.ts:108.
    • The table selection is lost on refresh anyway: The Members table keeps its selection in local React state at WorkspaceMembersPage.tsx:135. If the RHP stayed open after a reload, it would have no members to change.
    • Production already works this way: The domain members bulk-move RHP, MoveUsersBetweenGroupsPage.tsx:53-62, ships in 9.5.15-3. It also redirects back when a web refresh empties the selection.
    • Impact: Cosmetic. No data is lost, and you can select the members and click Change role again. Keeping the RHP open would mean persisting the table selection, which is a feature request.

    I didn't run the app. This conclusion comes from reading the code at staging HEAD and at the production tag.


    Next Steps: Krishna2323, please confirm this behavior is intended. If so, remove the DeployBlockerCash label. Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  9. JS00001 commented on Oct 22, 2026

    @JS00001
    Contributor

    This is expected, because we dont store the selected members in onyx and I dont think we should

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions