Skip to content

[Due for payment 2026-10-27] Payment issue for E/App PR#103309 #104496

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #103309
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/685831.
Contributor+ member who reviewed the PR - @QichenZhu.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    Author

    @QichenZhu The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Oct 23, 2026

    @melvin-bot
    Author

    @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. QichenZhu commented on Oct 26, 2026

    @QichenZhu
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A. New feature.
      Link to the comment on the Issue: N/A.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    1. As a submitter on a workspace with approvals, submit three reports to an approver.
    2. As the approver, reject one expense on the first report.
    3. As the approver, reject the whole second report.

    Test:

    1. As the submitter, go to Spend > Expenses and click Filters.
    2. Select Rejected > Yes.
    3. Verify a "Rejected: Yes" chip appears and only the rejected expense is listed.
    4. Change the chip to No.
    5. Verify the rejected expense is not listed and the other expenses are.
    6. Go to Spend > Reports and click Filters.
    7. Select Rejected > Yes.
    8. Verify only the second report is listed.
    9. Click the magnifying glass 🔍 icon in the top-right corner and type declined:.
    10. Verify the suggestions contain declined:no and declined:yes.
    11. Edit the query to type:expense -declined:yes and submit it.
    12. Verify the rejected expenses are not listed.

    Do we agree 👍 or 👎

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 26, 2026
  5. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  7. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    Author

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. mallenexpensify commented on Oct 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @QichenZhu due $175 via NewDot

  9. trjExpensify commented on Oct 30, 2026

    @trjExpensify
    Contributor

    approved $175 for @QichenZhu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions