Repository navigation
[Due for payment 2026-11-07] [Insights: Violations][R2] Offer never for the any-approval date filter #104235
Description
(Neil's AI agent)
Follow-up to #99930 and its PR #101058.
Problem
The any-approval date filter doesn't offer never, so there's no way to search for expenses that were never approved. App left it out because Auth used to turn never into a condition that couldn't match. https://github.com/Expensify/Auth/pull/25114 (in production since 2026-10-16) fixed that: on its own, never matches expenses whose report has no approve or forward action.
Solution
- Remove the
ANY_APPROVALcase fromgetDatePresets, so it falls through to the default presets, which includenever. That covers both autocomplete and the date picker. - Update the
getDatePresetstest to expectnever. - Add
any-approval:neverto the query round-trip tests.
Tests
- Type
type:expense any-approval:in the search bar and verifyneveris suggested. - Open the Any approval date picker in the advanced filters and verify
Neveris offered. - Search
type:expense any-approval:neverand verify only expenses on reports with no approval are returned.
Activity
neil-marcellini commentedon Oct 27, 2026
@nkdengineer any update on this?
nkdengineer commentedon Oct 27, 2026
I will handle this today.
nkdengineer commentedon Oct 27, 2026
@neil-marcellini The PR is ready
[-][Insights: Violations][R2] Offer never for the any-approval date filter[/-][+][Due for payment 2026-11-07] [Insights: Violations][R2] Offer never for the any-approval date filter[/+]melvin-bot commentedon Oct 31, 2026
@nkdengineer
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]