You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$175] Filters - Vendor option is missing in filters #104176
Preconditions:
User is an admin of a workspace connected to QBO with Export company card expenses set to Credit card
Workspace has at least one non-reimbursable expense with a vendor assigned and one without
On current main, the expense filter list has no VENDOR entry. TAG is followed directly by TAX_RATE in src/hooks/useAdvancedSearchFilters.ts:39-41. The QBO + Credit card setup is not the cause. That workspace passes the vendor feature gate in src/libs/PolicyUtils/vendor.ts:20-23, which is why the Vendor column still appears.
What changes do you think we should make in order to solve the problem?
No new fix is needed on this issue. The work is already in progress:
Bring the filter back by reverting the revert, combined with the picker fix in List workspace vendors from connections in the Search Vendor filter. That PR is open but has merge conflicts. It was branched before the revert, so it also needs to re-apply the original filter PR.
When the filter is re-landed, gate it with useIsVendorColumnAvailable so the Vendor column and the Vendor filter always appear together.
Until then, hold or close this issue, and mark the regression test case as blocked on the PR in step 1.
Investigation details
CONST.SEARCH.SYNTAX_FILTER_KEYS.VENDOR still exists (src/CONST/index.ts:8326). Only violation messages use it now, not Search filters.
The search parser, the advanced filters form type and SearchQueryUtils.ts have no vendor support. VendorSelector.tsx and useLoadSearchVendorData.ts were deleted by the revert.
The revert's own QA step says "Verify there is no Vendor filter", so the current behavior is what that PR intended.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/104176) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Please re-state the problem that we are trying to solve in this issue.
The "Vendor" option is missing from the filter list in Search > Expenses for workspaces with accounting connections (such as QBO) where non-reimbursable expenses have vendors assigned.
What is the root cause of that problem?
In src/libs/SearchUIUtils.ts and src/pages/Search/SearchAdvancedFiltersPage.tsx, the search filter configuration defines the visible filter fields via FILTER_VIEW_MAP. The key CONST.SEARCH.SYNTAX_FILTER_KEYS.VENDOR is missing from the filter list mapping for the EXPENSES search type, preventing users from filtering expenses by vendor even when vendor data exists on transactions.
What changes do you think we should make in order to solve the problem?
In src/libs/SearchUIUtils.ts, include CONST.SEARCH.SYNTAX_FILTER_KEYS.VENDOR in FILTER_VIEW_MAP and ensure getFilterMenuItems returns the Vendor option when the search type is EXPENSES.
Ensure the Vendor filter navigates to the vendor selection page (ROUTES.SEARCH_ADVANCED_FILTERS_VENDOR.getRoute()) and serializes to the vendor: search query parameter.
What alternative solutions did you explore? (Optional)
Relying solely on free-text search in the search bar, which does not provide structured vendor autocompletion or exact matching.
Tests
Log in as an admin of a workspace connected to QBO with non-reimbursable expenses.
Navigate to Search > Expenses.
Click "Filters".
Verify "Vendor" appears in the filter list options.
Select a vendor and verify the search results are filtered correctly by vendor:"...".
@suneox this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
applause-bot commentedon Oct 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/dc6da9e6b1d55f79410b0fb8fc6b353786b8c4128294e3d8b1095d2340dc34ba
MelvinBot commentedon Oct 16, 2026
Proposal
What is the root cause of that problem?
This is not a code regression. The Vendor filter was removed on purpose before it reached production, and the regression test case was not updated.
On current
main, the expense filter list has noVENDORentry.TAGis followed directly byTAX_RATEinsrc/hooks/useAdvancedSearchFilters.ts:39-41. The QBO + Credit card setup is not the cause. That workspace passes the vendor feature gate insrc/libs/PolicyUtils/vendor.ts:20-23, which is why the Vendor column still appears.What changes do you think we should make in order to solve the problem?
No new fix is needed on this issue. The work is already in progress:
useIsVendorColumnAvailableso the Vendor column and the Vendor filter always appear together.Investigation details
CONST.SEARCH.SYNTAX_FILTER_KEYS.VENDORstill exists (src/CONST/index.ts:8326). Only violation messages use it now, not Search filters.SearchQueryUtils.tshave no vendor support.VendorSelector.tsxanduseLoadSearchVendorData.tswere deleted by the revert.Related open issue: [$175] Spend - Unable to sort expenses by Vendor is about the Vendor column, not the filter.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/104176)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
j3ffffff commentedon Oct 16, 2026
melvin-bot commentedon Oct 16, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)[-]Filters - Vendor option is missing in filters[/-][+][$175] Filters - Vendor option is missing in filters[/+]melvin-bot commentedon Oct 16, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022110885193812397155
camesenin commentedon Oct 16, 2026
melvin-bot commentedon Oct 16, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
jloa-dev commentedon Oct 19, 2026
Contributor details
Your Expensify account email: jloa.dev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01584ea0bc208b0a94
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Vendor" option is missing from the filter list in Search > Expenses for workspaces with accounting connections (such as QBO) where non-reimbursable expenses have vendors assigned.
What is the root cause of that problem?
In
src/libs/SearchUIUtils.tsandsrc/pages/Search/SearchAdvancedFiltersPage.tsx, the search filter configuration defines the visible filter fields viaFILTER_VIEW_MAP. The keyCONST.SEARCH.SYNTAX_FILTER_KEYS.VENDORis missing from the filter list mapping for theEXPENSESsearch type, preventing users from filtering expenses by vendor even when vendor data exists on transactions.What changes do you think we should make in order to solve the problem?
src/libs/SearchUIUtils.ts, includeCONST.SEARCH.SYNTAX_FILTER_KEYS.VENDORinFILTER_VIEW_MAPand ensuregetFilterMenuItemsreturns the Vendor option when the search type isEXPENSES.ROUTES.SEARCH_ADVANCED_FILTERS_VENDOR.getRoute()) and serializes to thevendor:search query parameter.What alternative solutions did you explore? (Optional)
Relying solely on free-text search in the search bar, which does not provide structured vendor autocompletion or exact matching.
Tests
vendor:"...".4 remaining items
melvin-bot commentedon Oct 30, 2026
@suneox this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
suneox commentedon Nov 4, 2026
The Vendor filter is back on production in
v9.5.24-8via #104351so @Expensify/applause we can re-verify then close this issue.
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026