You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-02] Vendors - Vendor list cannot be bulk selected #103556
Version Number: 9.5.6-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102756 Email or phone of affected tester (no customers):applausetester+ii_0610n2@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: iPhone 15 iOS 26.6.1 App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Cause:Add imported vendor enable and disable controls (high confidence). That PR added bulk selection to the Vendors page, but on narrow layouts (native) it can never be turned on. Long-press is the only way to enter selection mode, and both of the checks below block it.
Recommendation: Roll forward with the two-line fix below, or demote. This is a new feature that isn't in production, and it affects only mobile bulk select. Don't revert, because that would also remove the working enable/disable toggles.
TableRow.handleRowLongPress opens the "Select" sheet only if selectionEnabled and interactive are both true. The Vendors page fails both checks:
interactive={false} is left over from the old read-only vendors table. The PR added the selection props but kept the row non-interactive. Other selectable rows, such as Taxes and Per Diem, are interactive.
canSelectMultiple = canWriteVendors && (shouldUseNarrowLayout ? isMobileSelectionModeEnabled : true) is false on narrow layouts until selection mode is on. Only long-press turns selection mode on, so it can never become true. Other pages pass the write permission directly and let Table hide checkboxes until selection mode starts. Examples are WorkspaceCategoriesPage.tsx:712 and WorkspaceTaxesPage.tsx:424.
changed the title [-]Vendors - Vendor list cannot be bulk selected[/-][+][Due for payment 2026-11-02] Vendors - Vendor list cannot be bulk selected[/+]on Oct 26, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 9, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/fdbd0050ff5c27c4a8c520ee6814c1ec252b25554cfcaafaefda6f7a58bc4a24
melvin-bot commentedon Oct 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102756
melvin-bot commentedon Oct 9, 2026
@Beamanator @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102756
melvin-bot commentedon Oct 9, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102756
github-actions commentedon Oct 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 9, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 9, 2026
Deploy Blocker Analysis
Cause: Add imported vendor enable and disable controls (high confidence). That PR added bulk selection to the Vendors page, but on narrow layouts (native) it can never be turned on. Long-press is the only way to enter selection mode, and both of the checks below block it.
Recommendation: Roll forward with the two-line fix below, or demote. This is a new feature that isn't in production, and it affects only mobile bulk select. Don't revert, because that would also remove the working enable/disable toggles.
Fix (both changes are needed):
WorkspaceVendorsTable/index.tsx:92, changeinteractive={false}tointeractive={selectionEnabled}.WorkspaceVendorsPage.tsx:271, passselectionEnabled={canWriteVendors}. Then remove the unusedcanSelectMultipleat line 145.Investigation details
TableRow.handleRowLongPressopens the "Select" sheet only ifselectionEnabledandinteractiveare both true. The Vendors page fails both checks:interactive={false}is left over from the old read-only vendors table. The PR added the selection props but kept the row non-interactive. Other selectable rows, such as Taxes and Per Diem, are interactive.canSelectMultiple = canWriteVendors && (shouldUseNarrowLayout ? isMobileSelectionModeEnabled : true)isfalseon narrow layouts until selection mode is on. Only long-press turns selection mode on, so it can never becometrue. Other pages pass the write permission directly and letTablehide checkboxes until selection mode starts. Examples areWorkspaceCategoriesPage.tsx:712andWorkspaceTaxesPage.tsx:424.Other staging PRs: Of the 67 PRs on Deploy Checklist: New Expensify 2026-10-08, only the vendor controls PR touches the Vendors page or mobile selection mode.
Related: Vendors - Vendor list is empty is a separate bug and a step needed to reproduce this one. It isn't the cause.
Not verified on a device. This is a native long-press bug, and it can't be reproduced in the web test environment.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.2 remaining items
IuliiaHerets commentedon Oct 9, 2026
iPhone 15 build 9.5.6-5: no controls in Vendors, reverted. Not repro
5cbfc3e0b0a78241dd09a214e59575de.mp4
jponikarchuk commentedon Oct 23, 2026
Deploy Blocker #104891 was identified to be related to the PR #103549 that attempted to fix this issue.
melvin-bot commentedon Oct 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Oct 23, 2026
Deploy Blocker #104892 was identified to be related to the PR #103549 that attempted to fix this issue.
melvin-bot commentedon Oct 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon Oct 23, 2026
Deploy Blocker #104894 was identified to be related to the PR #103549 that attempted to fix this issue.
melvin-bot commentedon Oct 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Beamanator commentedon Oct 23, 2026
i don't think we need to reopen this
[-]Vendors - Vendor list cannot be bulk selected[/-][+][Due for payment 2026-11-02] Vendors - Vendor list cannot be bulk selected[/+]melvin-bot commentedon Oct 26, 2026
@Pujan92
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]