[CFI] [$175] Show the Reimbursable toggle on company card expenses when the card feed is set to Do Not Force

@dmkt9

Coming from here, we want to show the Reimbursable toggle on company card expenses when the card feed allows the value to change, matching cash expenses and company card expenses in Expensify Classic.

Details

Today, New Expensify hides the Reimbursable toggle on every company card expense in the expense detail view and in bulk edit. Expensify Classic shows the toggle when the card feed is set to either Do Not Force option, but customers on those settings can't change reimbursability on card expenses in New Expensify.
The feed's Reimbursable setting doesn't exist in New Expensify yet. This issue doesn't need it: the toggle uses the forceReimbursable value stamped on each card expense at import.
Adding the feed setting to New Expensify is tracked separately: [CFI] Add a Reimbursable setting to company card feed settings in New Expensify #103342
Forced value: We will use the forceReimbursable value stamped on each card expense at import to decide whether the toggle appears. Changing the feed setting only affects expenses imported afterward, matching Classic.
- Force No (force_no, default): Toggle hidden.
- Force Yes (force_yes): Toggle hidden.
- Do Not Force (Defaults to Reimbursable) (default_yes): Toggle shown and editable.
- Do Not Force (Defaults to Non-Reimbursable) (default_no, or legacy none): Toggle shown and editable.
For new card transactions, the feed setting sets the starting value. Do Not Force (Defaults to Reimbursable) starts as reimbursable, and Do Not Force (Defaults to Non-Reimbursable) starts as non-reimbursable.
The Do Not Force settings don't restrict edits after an expense is imported, so users can change the value on each expense. The toggle shows each expense's current value.
The toggle uses the existing Reimbursable label, matching cash expenses in NewDot today.
Bulk edit expense: We will show the Reimbursable row when none of the selected expenses has a forced value stamped on it. Selections that mix cash and non-forced card expenses show the row. If any selected expense is forced to reimbursable/non-reimbursable, the row is hidden, matching how New Expensify already handles forced cash expenses.
This change does not apply Expensify Card transactions, which can never be reimbursable.

Existing reimbursable toggle on cash expenses

Existing reimbursable feed setting in Expensify Classic that controls whether we will show this reimbursable toggle on card expenses in New Expensify

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~022108287338260589209
Upwork Job ID: 2108287338260589209
Last Price Increase: 2026-10-08

Issue Owner

Current Issue Owner: @dmkt9

@dmkt9

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (External)

@dannymcclain

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

Job added to Upwork: https://www.upwork.com/jobs/~022108287338260589209

@dannymcclain

@dannymcclain I don't think we need any mocks here. This issue is just showing the existing reimbursable toggle on company card expenses based on an existing setting in Expensify Classic. Going ahead for now, but please let me know if you disagree. 👍

@MelvinBot

@MelvinBot In addition to the transaction values, we also need to check the policy settings #103342

Proposal (updated: also check feed and workspace settings)

Please re-state the problem that we are trying to solve in this issue.

New Expensify hides the Reimbursable toggle on every company card expense. We want to show it on company card expenses set to Do Not Force. The check should use the transaction's stamped value and the feed's Reimbursable setting from Add a Reimbursable setting to company card feed settings in New Expensify.

What is the root cause of that problem?

This is a new feature. Every reimbursable check hides the row when isManagedCardTransaction(transaction) is true. None of them read forceReimbursable from the transaction or the feed. The workspace Cash expenses rule (disabledFields.reimbursable) sits in the same condition, but it should only apply to cash expenses.

Code references

Expense view: MoneyRequestView.tsx:551-555
Split edit: DynamicSplitExpenseEditPage.tsx:269-272
Bulk edit: SearchEditMultiplePage.tsx:153-159. It requires disabledFields.reimbursable === false for every reported expense.
The feed setting already has a type: forceReimbursable on CustomCardFeedData (CardFeeds.ts:85), under settings.companyCards[feed] in sharedNVP_private_domain_member_<fundID>. Nothing reads it yet.
getFeedSettingsForCard already returns that object for a card.
MoneyRequestView already loads the expense's card and its feed data (lines 282-285).
The Cash expenses description says a cash expense is any expense that isn't an imported company card transaction (cashExpenseDefaultDescription in en.ts).

What changes do you think we should make in order to solve the problem?

Add CONST.COMPANY_CARD.FORCE_REIMBURSABLE with force_yes, force_no, default_yes, default_no and none.
Add forceReimbursable to the transaction Comment type, next to liabilityType.
Add isCardTransactionReimbursableEditable(transaction, feedSettings) to TransactionUtils. It returns:
- true for non-card expenses, so cash behavior doesn't change.
- false for Expensify Card expenses.
- false if the transaction's stamped value is forced.
- false if the feed setting is forced. If the feed settings exist but have no value, treat it as force_no, per the feed settings issue.
- true only when the stamped value is Do Not Force and the feed isn't forced. If the stamp is missing, use the feed setting. If both are missing, return false.
Get feed settings with getFeedSettingsForCard(card, allCardFeeds). If the viewer has no feed data, use the stamped value alone.
For company card expenses, skip the workspace Cash expenses rule. Keep the expense-report, unreported and invoice checks. This fixes the cases zeryns reported, such as the toggle disappearing after one change.
Use the helper in the expense view, split edit and bulk edit. In bulk edit, look up each card from NON_PERSONAL_AND_WORKSPACE_CARD_LIST and its feed from the SHARED_NVP_PRIVATE_DOMAIN_MEMBER collection. Hide the row if any selected card expense is forced.

Tests:

Helper unit tests for each combination of stamped and feed values, plus missing values, Expensify Card and cash expenses.
A default_yes card expense on a feed changed to force_no hides the row.
A Do Not Force card expense on an "Always non-reimbursable" workspace shows the toggle, and it stays visible after toggling.
In bulk edit, Do Not Force card expenses on an "Always" workspace show the row. A selection with one forced card expense hides it.

Open questions

Product (joekaufmanexpensify): The issue says feed changes only affect newly imported expenses. Checking the current feed setting changes that: switching a feed to Force hides the toggle on older Do Not Force expenses. Please confirm that's intended.
Backend: Please confirm that approvers who aren't admins receive sharedNVP_private_domain_member_<fundID>. If they don't, they only get the stamped value. Please also confirm the stamped transaction key (I assumed comment.forceReimbursable) and that search results include it.

What alternative solutions did you explore? (Optional)

Use only the stamped value, as in my previous proposal. That ignores the feed setting and leaves the workspace Cash expenses rule applied to card expenses.

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/103341) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

view run

@MelvinBot

Changing the feed setting only affects expenses imported afterward, matching Classic

@MelvinBot Only check feedSettings if the value doesn't exist in the transaction

Proposal (updated: feed setting is only a fallback)

Please re-state the problem that we are trying to solve in this issue.

New Expensify hides the Reimbursable toggle on every company card expense. We want to show it on company card expenses set to Do Not Force. The transaction's stamped forceReimbursable decides. The feed's Reimbursable setting from Add a Reimbursable setting to company card feed settings in New Expensify is used only when the transaction has no stamped value. This way, changing the feed setting only affects expenses imported afterward, matching Classic.

What is the root cause of that problem?

This is a new feature. Every reimbursable check hides the row when isManagedCardTransaction(transaction) is true. None of them read forceReimbursable from the transaction or the feed. The workspace Cash expenses rule (disabledFields.reimbursable) sits in the same condition, but it should only apply to cash expenses.

Code references

Expense view: MoneyRequestView.tsx:551-555
Split edit: DynamicSplitExpenseEditPage.tsx:269-272
Bulk edit: SearchEditMultiplePage.tsx:153-159. It requires disabledFields.reimbursable === false for every reported expense.
The feed setting already has a type: forceReimbursable on CustomCardFeedData (CardFeeds.ts:85), under settings.companyCards[feed] in sharedNVP_private_domain_member_<fundID>. Nothing reads it yet.
getFeedSettingsForCard already returns that object for a card.
MoneyRequestView already loads the expense's card and its feed data (lines 282-285).
The Cash expenses description says a cash expense is any expense that isn't an imported company card transaction (cashExpenseDefaultDescription in en.ts).

What changes do you think we should make in order to solve the problem?

Add CONST.COMPANY_CARD.FORCE_REIMBURSABLE with force_yes, force_no, default_yes, default_no and none.
Add forceReimbursable to the transaction Comment type, next to liabilityType.
Add isCardTransactionReimbursableEditable(transaction, feedSettings) to TransactionUtils. It returns:
- true for non-card expenses, so cash behavior doesn't change.
- false for Expensify Card expenses.
- If the transaction has a stamped value, it uses only that value: true for default_yes, default_no or none, and false for force_yes or force_no. The feed setting is ignored.
- If the transaction has no stamped value, it uses the feed setting the same way. If the feed settings exist but have no value, treat it as force_no, per the feed settings issue.
- false if both values are missing.
Get feed settings with getFeedSettingsForCard(card, allCardFeeds). Look them up only when the transaction has no stamped value.
For company card expenses, skip the workspace Cash expenses rule. Keep the expense-report, unreported and invoice checks. This fixes the cases zeryns reported, such as the toggle disappearing after one change.
Use the helper in the expense view, split edit and bulk edit. In bulk edit, look up each card from NON_PERSONAL_AND_WORKSPACE_CARD_LIST and its feed from the SHARED_NVP_PRIVATE_DOMAIN_MEMBER collection. Hide the row if any selected card expense is forced.

Tests:

Helper unit tests for each stamped value, each feed value with no stamp, both missing, Expensify Card and cash expenses.
A default_yes card expense on a feed later changed to force_no still shows the row.
A force_no card expense on a feed later changed to default_yes still hides the row.
A card expense with no stamp on a default_no feed shows the row.
A Do Not Force card expense on an "Always non-reimbursable" workspace shows the toggle, and it stays visible after toggling.
In bulk edit, Do Not Force card expenses on an "Always" workspace show the row. A selection with one forced card expense hides it.

Open questions for the internal engineer

Please confirm the stamped transaction key (I assumed comment.forceReimbursable) and that search results include it.
For expenses with no stamp, please confirm that approvers who aren't admins receive sharedNVP_private_domain_member_<fundID>. If they don't, those expenses stay hidden for them.

What alternative solutions did you explore? (Optional)

Check both the stamped value and the current feed setting, as in my previous update. That makes a feed change affect expenses that were already imported, which doesn't match Classic.

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/103341) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

view run

MelvinBot's proposal looks good to me

🎀 👀 🎀 C+

@blimpich

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@dmkt9

LGTM, feel free to ask Melving to raise the PR @dmkt9 👍

@MelvinBot

@MelvinBot implement this #103341 (comment)

🤖 Draft PR created: Show the Reimbursable toggle on Do Not Force company card expenses
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.

It follows the approved proposal:

Which value decides: The value stamped on the expense decides. The feed setting is used only when the expense has no stamped value.
Workspace rule: Card expenses skip the workspace Cash expenses rule.
Where it applies: The expense view, split edit and bulk edit.

Typecheck, lint, spelling and the related Jest suites pass, including 17 new tests. I didn't test it manually in the app, because a fresh test account has no company card expenses with a stamped value.

The backend key is still unconfirmed. I assumed the stamped value is comment.forceReimbursable, and search results need to include it too.

view run

@dmkt9

📣 @dmkt9 We're missing your Upwork ID to automatically send you an offer for the Reviewer role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

PR review ongoing.

Navigation Menu

Repository navigation

[CFI] [$175] Show the Reimbursable toggle on company card expenses when the card feed is set to Do Not Force #103341

Details

Existing reimbursable toggle on cash expenses

Existing reimbursable feed setting in Expensify Classic that controls whether we will show this reimbursable toggle on card expenses in New Expensify

18 remaining items

Proposal (updated: also check feed and workspace settings)

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal (updated: feed setting is only a fallback)

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[CFI] [$175] Show the Reimbursable toggle on company card expenses when the card feed is set to Do Not Force #103341

Description

Details

Existing reimbursable toggle on cash expenses

Existing reimbursable feed setting in Expensify Classic that controls whether we will show this reimbursable toggle on card expenses in New Expensify

Activity

melvin-bot commented on Oct 8, 2026

melvin-bot commented on Oct 8, 2026

melvin-bot commented on Oct 8, 2026

joekaufmanexpensify commented on Oct 8, 2026

18 remaining items

dmkt9 commented on Oct 14, 2026

MelvinBot commented on Oct 14, 2026

Proposal (updated: also check feed and workspace settings)

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dmkt9 commented on Oct 14, 2026

MelvinBot commented on Oct 14, 2026

Proposal (updated: feed setting is only a fallback)

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dmkt9 commented on Oct 14, 2026

melvin-bot commented on Oct 14, 2026

blimpich commented on Oct 14, 2026

dmkt9 commented on Oct 15, 2026

MelvinBot commented on Oct 15, 2026

melvin-bot commented on Oct 16, 2026

joekaufmanexpensify commented on Oct 26, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions