Skip to content

[Due for payment 2026-10-30] R2: Show Ashby-specific Advanced approver fields #103091

Open

Description

@yuwenmemon

Parent: https://github.com/Expensify/Expensify/issues/637628
Design doc: https://docs.google.com/document/d/1a-CNZhDMXqLSBw33k6IfJKhw4GfdK0_QB9Fxq5WFefw/edit
Related: https://github.com/Expensify/Expensify/issues/675427 and https://github.com/Expensify/Expensify/issues/675428

Scope

Make the Recruiting Advanced-approval field selector show the roles supported by the connected ATS provider. Ashby offers Recruiter, Hiring Manager, and Recruiting Coordinator; Greenhouse continues to offer Recruiter and Recruiting Coordinator.

Implementation notes (from design doc)

  • Extend src/CONST/index.ts with the Ashby Hiring Manager approver-field value. Use the value accepted by Web's provider-specific validation in #675428.
  • Update src/pages/workspace/recruiting/approver/MergeATSApproverFieldPage.tsx to derive its options from the connected provider instead of displaying every value in CONST.MERGE.ATS_APPROVER_FIELD.
  • Update src/pages/workspace/recruiting/utils.ts so the selected Hiring Manager value has a readable label on the approval page and Recruiting card.
  • Add the English and Spanish translation strings. Keep the existing Greenhouse options and saved values working.
  • Verify the approval draft and Save flow sends the Ashby selection to the existing UpdateMergeApprovalMode or UpdateMergeATSApproverField command.

Tests

  • Greenhouse shows only Recruiter and Recruiting Coordinator.
  • Ashby shows Recruiter, Hiring Manager, and Recruiting Coordinator.
  • A saved Ashby Hiring Manager selection appears correctly when the admin reopens the page and on the Recruiting card.
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Oct 5, 2026
  2. melvin-bot commented on Oct 5, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  3. shawnborton commented on Oct 6, 2026

    @shawnborton
    Contributor

    Anything needed from Design here?

  4. bernhardoj commented on Oct 6, 2026

    @bernhardoj
    Contributor

    I think no

  5. trjExpensify commented on Oct 12, 2026

    @trjExpensify
    Contributor

    Same here, going to move this to #convert as discussed.

  6. self-assigned this
    on Oct 19, 2026
  7. changed the title [-]R2: Show Ashby-specific Advanced approver fields[/-] [+][Due for payment 2026-10-30] R2: Show Ashby-specific Advanced approver fields[/+] on Oct 23, 2026
  8. melvin-bot commented on Oct 23, 2026

    @melvin-bot

    @bernhardoj / @DylanDylann

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-30. 🎊

    Contributor+ Checklist: The following checklist (instructions) needs to be completed before this issue can be closed:

    • [@bernhardoj / @DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

    If no checklist is needed for this issue, use the K2 [no checklist button].

  9. melvin-bot commented on Oct 26, 2026

    @melvin-bot

    @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. DylanDylann commented on Oct 28, 2026

    @DylanDylann
    Contributor

    Not overdue. And no payment required

  11. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    @bernhardoj Eep! 4 days overdue now. Issues have feelings too...

  12. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.Overdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions