You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-21] [$175] Not here page opens when creating new workspace from FAB on Account and Insights tab #102095
WORKSPACE_CONFIRMATION is a dynamic route — it is appended as a suffix to whatever path is currently active, and it is only allowed to open from a whitelist of screens (src/ROUTES.ts:235-238):
The FAB item calls createDynamicRoute(...)with no basePath (NewWorkspaceMenuItem.tsx:58), so the base path is whatever getActiveRoute() returns (createDynamicRoute.ts:77). On the two broken tabs that active path resolves to a screen that is not in the whitelist:
Account tab, wide layout:SettingsSplitNavigator pushes SCREENS.SETTINGS.PROFILE.ROOT as the central pane and makes it the focused route (SettingsSplitNavigator.tsx:46, SplitRouter.ts:117). The URL is settings/profile, not settings, so the built route is settings/profile/workspace/confirmation. SETTINGS.PROFILE.ROOT is not whitelisted — only SETTINGS.ROOT is.
Insights tab: the active path is insights/:dashboardID → focused route SCREENS.INSIGHTS, which is not in the list at all.
The whitelist check fails at getStateFromPath.ts:49, the path falls through to React Navigation's parser, matches nothing, and lands on the '*' → SCREENS.NOT_FOUND catch-all (config.ts:40) — the "Not here" page.
This also explains why only Windows: Chrome and MacOS: Chrome/Safari are ticked: on a narrow layout the split navigator pushes no central pane, so the Account tab URL stays settings, SETTINGS.ROOT matches, and the flow works.
What changes do you think we should make in order to solve the problem?
The FAB is rendered in the navigation tab bar, so it is reachable from every tab and every central-pane screen. The whitelist for this one route should reflect that — widen DYNAMIC_ROUTES.WORKSPACE_CONFIRMATION.entryScreens in src/ROUTES.ts:237 to ['*'], which the validator already supports and which ~10 other dynamic routes already use.
Add a case to tests/navigation/workspaceConfirmationEntryScreensTest.ts asserting that settings/profile/workspace/confirmation and insights/<dashboardID>/workspace/confirmation resolve to the confirmation screen rather than SCREENS.NOT_FOUND.
No change is needed to the child routes (currency, plan type, owner selector) — they key off SCREENS.WORKSPACE_CONFIRMATION.DYNAMIC_ROOT and work once the root opens.
What alternative solutions did you explore? (Optional)
Two narrower options and why I'd not pick them
1. Enumerate the missing screens — add SCREENS.INSIGHTS plus every Account-tab central screen (SETTINGS.PROFILE.ROOT, SETTINGS.WALLET.ROOT, SETTINGS.SECURITY, …). This fixes the reported repro but is fragile: any new settings page or new tab silently reintroduces the bug, because the FAB is global and the whitelist is not.
2. Pass a fixed basePath to createDynamicRoute in NewWorkspaceMenuItem, the way WorkspaceListTable passes ROUTES.WORKSPACES_LIST.route. This works, but it changes what sits behind the RHP and where dismiss returns the user, so it's a UX change rather than a bug fix.
Not verified in a browser. Browser control was unavailable for this run, so this is static analysis of the navigation code only. Worth confirming the URL on the Account tab really reads settings/profile before implementing.
Possibly related
Teacher Unite - QAB open not here page (Expensify/App#101092) — open, same "Not here from the FAB on Windows Chrome" family, different dynamic route (QAB). May share the entry-screen validation root cause.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/102095) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
@MelvinBot , why wasn't @dmkt9 sent a job offer in Upwork? They've been a contributor for a while. If they need to enter their Upwork details again, please share exactly what they need to enter. cc @akinwale cuz we've been working on fixing the integration.
The bot has never stored an Upwork ID for dmkt9, so it can't send them an automatic offer. Their contributor details (email and profile link) are already on file, so re-entering those won't help. Reposting them just returns 401 Contributor details already exist.
The bot stores the Upwork ID only when the contributor applies to a bot-created Upwork job. dmkt9 has been paid through manual BZ offers, which skip that step. As a result, the bot has posted "We're missing your Upwork ID" on about 37 of their issues since March.
I can't see the bot's internal code, so this is based on its public comments. If dmkt9 has already applied to a bot-created job and still gets the prompt, the ID capture is broken. That needs an internal check.
Possibly related to the integration work: Upwork job auto-creation fails more often now. "Unable to auto-create job on Upwork" appears on about 27% of issues created since June, compared with about 7% from January to May. That didn't cause this case, because the jobs on dmkt9's issues were created fine.
What dmkt9 needs to do: submit a proposal on Upwork, from the same account as their profile link, to the job in the latest prompt: upwork.com/jobs/~022108111025467606168 on #103430. They don't need to post anything on GitHub.
@dmkt9 can plz do so and confirm once you have? Thx
@dmkt9 can plz do so and confirm once you have? Thx
@mallenexpensify I'm seeing this message: "This job is private. Only freelancers invited by the client can view this job." I can't view the job details.
Activity
applause-bot commentedon Sep 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e651876098750de3d5c0040c96408e30052ef7ba2eb877ea89e85b8d117742e5
MelvinBot commentedon Sep 23, 2026
Proposal
What is the root cause of that problem?
WORKSPACE_CONFIRMATIONis a dynamic route — it is appended as a suffix to whatever path is currently active, and it is only allowed to open from a whitelist of screens (src/ROUTES.ts:235-238):The FAB item calls
createDynamicRoute(...)with nobasePath(NewWorkspaceMenuItem.tsx:58), so the base path is whatevergetActiveRoute()returns (createDynamicRoute.ts:77). On the two broken tabs that active path resolves to a screen that is not in the whitelist:SettingsSplitNavigatorpushesSCREENS.SETTINGS.PROFILE.ROOTas the central pane and makes it the focused route (SettingsSplitNavigator.tsx:46,SplitRouter.ts:117). The URL issettings/profile, notsettings, so the built route issettings/profile/workspace/confirmation.SETTINGS.PROFILE.ROOTis not whitelisted — onlySETTINGS.ROOTis.insights/:dashboardID→ focused routeSCREENS.INSIGHTS, which is not in the list at all.The whitelist check fails at
getStateFromPath.ts:49, the path falls through to React Navigation's parser, matches nothing, and lands on the'*'→SCREENS.NOT_FOUNDcatch-all (config.ts:40) — the "Not here" page.This also explains why only Windows: Chrome and MacOS: Chrome/Safari are ticked: on a narrow layout the split navigator pushes no central pane, so the Account tab URL stays
settings,SETTINGS.ROOTmatches, and the flow works.What changes do you think we should make in order to solve the problem?
The FAB is rendered in the navigation tab bar, so it is reachable from every tab and every central-pane screen. The whitelist for this one route should reflect that — widen
DYNAMIC_ROUTES.WORKSPACE_CONFIRMATION.entryScreensinsrc/ROUTES.ts:237to['*'], which the validator already supports and which ~10 other dynamic routes already use.Add a case to
tests/navigation/workspaceConfirmationEntryScreensTest.tsasserting thatsettings/profile/workspace/confirmationandinsights/<dashboardID>/workspace/confirmationresolve to the confirmation screen rather thanSCREENS.NOT_FOUND.No change is needed to the child routes (currency, plan type, owner selector) — they key off
SCREENS.WORKSPACE_CONFIRMATION.DYNAMIC_ROOTand work once the root opens.What alternative solutions did you explore? (Optional)
Two narrower options and why I'd not pick them
1. Enumerate the missing screens — add
SCREENS.INSIGHTSplus every Account-tab central screen (SETTINGS.PROFILE.ROOT,SETTINGS.WALLET.ROOT,SETTINGS.SECURITY, …). This fixes the reported repro but is fragile: any new settings page or new tab silently reintroduces the bug, because the FAB is global and the whitelist is not.2. Pass a fixed
basePathtocreateDynamicRouteinNewWorkspaceMenuItem, the wayWorkspaceListTablepassesROUTES.WORKSPACES_LIST.route. This works, but it changes what sits behind the RHP and where dismiss returns the user, so it's a UX change rather than a bug fix.Not verified in a browser. Browser control was unavailable for this run, so this is static analysis of the navigation code only. Worth confirming the URL on the Account tab really reads
settings/profilebefore implementing.Possibly related
Expensify/App#101092) — open, same "Not here from the FAB on Windows Chrome" family, different dynamic route (QAB). May share the entry-screen validation root cause.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/102095)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Sep 23, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (
External)melvin-bot commentedon Sep 23, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
naufalfx805-source commentedon Sep 24, 2026
naufalfx805-source commentedon Sep 24, 2026
melvin-bot commentedon Sep 24, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
melvin-bot commentedon Sep 28, 2026
@dmkt9 Eep! 4 days overdue now. Issues have feelings too...
dmkt9 commentedon Sep 29, 2026
MelvinBot's proposal looks good to me
🎀 👀 🎀 C+
28 remaining items
melvin-bot commentedon Oct 20, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 20, 2026
Payment Summary
Resolving PRs:
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 21, 2026
Payment Summary
Contributor+: @dmkt9 due $175 via Upwork
@dmkt9 paid, summary updated above. Thx.
https://www.upwork.com/jobs/~022109560758800481392
mallenexpensify commentedon Oct 21, 2026
@MelvinBot , why wasn't @dmkt9 sent a job offer in Upwork? They've been a contributor for a while. If they need to enter their Upwork details again, please share exactly what they need to enter. cc @akinwale cuz we've been working on fixing the integration.
MelvinBot commentedon Oct 21, 2026
The bot has never stored an Upwork ID for
dmkt9, so it can't send them an automatic offer. Their contributor details (email and profile link) are already on file, so re-entering those won't help. Reposting them just returns401 Contributor details already exist.The bot stores the Upwork ID only when the contributor applies to a bot-created Upwork job.
dmkt9has been paid through manual BZ offers, which skip that step. As a result, the bot has posted "We're missing your Upwork ID" on about 37 of their issues since March.What
dmkt9needs to do: submit a proposal on Upwork, from the same account as their profile link, to the job in the latest prompt: upwork.com/jobs/~022108111025467606168 on [$175] Choosing a large file to share doesn't redirect App to Home after attach error msg appears. They don't need to post anything on GitHub.Caveats
dmkt9has already applied to a bot-created job and still gets the prompt, the ID capture is broken. That needs an internal check.dmkt9's issues were created fine.view run
mallenexpensify commentedon Oct 21, 2026
@dmkt9 can plz do so and confirm once you have? Thx
dmkt9 commentedon Oct 22, 2026
@mallenexpensify I'm seeing this message: "This job is private. Only freelancers invited by the client can view this job." I can't view the job details.
mallenexpensify commentedon Oct 22, 2026
@dmkt9 I just made this job public, can you submit a proposal on it?
https://www.upwork.com/jobs/~022108111025467606168
@dmkt9 , can you please accept the job below (for payment on this job)? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022113380053525892208