Add support for Django 1.11 and 2.x#9
Open
Javierb wants to merge 1 commit into
Open
Conversation
Collaborator
|
Does removal of |
Author
|
Haven't tested in older versions. Do you really want to support un-supported versions of Django? |
Collaborator
|
Since this module is 4 years old, it's in use in older systems. If an important bug is fixed in this module, people most likely don't want to go through a django upgrade process to fix a bug in a small module. |
|
Can we merge this? Im using django 2 and it is not working because of Attribute error regarding renderer.. |
Collaborator
|
@josefkorbel If you're using pip, you can install directly from the branch: https://github.com/Javierb/django-better-filter-widget/tree/django-1-11-and-2-x-support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the render choices parameter to renderer as per the base class "Widget", otherwise "AttributeError: 'tuple' object has no attribute 'render'" is raised.
In the Django documentation is stated that support for subclasses that don’t accept the renderer parameter will be removed in Django 2.1.