ci: consolidate release workflows into a single release.yml#5
Merged
Conversation
Remove the legacy release.yaml (inherited from upstream) which duplicated the release flow, created a stray release/<version> branch + version-bump commit, and produced a second draft release. The branch-creation step also collides whenever a release PR branch is named release/<version>. release.yml is now the single source: it builds both linux/amd64 and linux/arm64, emits a combined checksums.txt, and creates a draft release with generated notes for maintainer review before publishing.
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo had two workflows triggering on
v*tags — the modernrelease.ymland the legacy upstreamrelease.yaml— which both created draft GitHub releases and built binaries. During thev1.0.2cut,release.yamlfailed:Its "Create release branch" step tries to create
release/<version>, which collides whenever a release PR branch already uses that name (as ours did). It also pushes a straybump version for releasecommit and produces a second duplicate draft release.This removes
release.yamland makesrelease.ymlthe single source of truth. The only capabilityrelease.yamlhad thatrelease.ymllacked was the arm64 binary, sorelease.ymlnow builds both arches:checksums.txtnow covers both binaries, and the draft release attacheswings_linux_amd64,wings_linux_arm64, andchecksums.txt. Release staysdraft: truefor maintainer review before publishing (unchanged behavior).No
release/<version>branch is created anymore — that pattern was the source of the collision and the stray version-bump commits.Note
The
v1.0.2release itself is already published (latest) with both binaries + checksums; the container image and Helm chart published successfully. This PR only fixes the workflow for future releases.Link to Devin session: https://app.devin.ai/sessions/c6e2874ef8924e68a929e491c2018270
Requested by: @Exonical