Expanded web tests#679
Merged
Merged
Conversation
… added radius to circles in limb darkening plot
hayescr
approved these changes
May 11, 2026
Collaborator
hayescr
left a comment
hayescr
left a comment
There was a problem hiding this comment.
@york-stsci I took a look at these changes and generally they look good to me. I had two potential suggestions you might consider, but if you'd rather not implement them, I'm happy to approve this PR.
hayescr
approved these changes
May 15, 2026
Collaborator
hayescr
left a comment
hayescr
left a comment
There was a problem hiding this comment.
Sorry for the delay on getting back to these changes, but they look good to me, and I think it's fine to push moving the specific form parameterizations to yaml files in a separate PR. Thanks for the additional documentation on what each set of form actions are doing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the remaining exoctk website modes. In addition, as part of the process, it also includes: