You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ah, so I think the problem here is the following. On 32bit systems saidx64_t is bigger than size_t. Hence the shift is larger than the underlying type and produces a warning. (Not sure why debian gets a build failure without seeing the error. I hope they don't compile with -Werror?) The better fix would be to shift left depending on min(sizeof(size_t), sizeof(saidx64_t)).
Then there is also the more subtle issue of trying to read a sequence that doesn't fit into memory/size_t. Not sure what is the best way to prevent that.
@kloetzlf1463b7 ? Okay, I'll do a test later this weekend, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for a476126 ; I had to add the contents of this PR as well to fix the 32-bit builds of Phylonium for Debian.
Possibly this was also needed because we define
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64on armel/armhf?