Repository navigation
fix(plugin-raven): track SearchConfig's top_k default of 2 - #25
Merged
Merged
Conversation
cyfyifanchen
approved these changes
Sep 8, 2026
The multi-source release (#7) narrowed the default from 5 to 2 across the engine, Hermes and both TypeScript hosts. This schema was the one place left behind, and the line has not been touched since the file was created. Raven's plugin registry fills a declared default for every key the operator leaves out, so a zero-config Raven was the only host injecting five full skill bodies per search instead of two — and on the default path there is no gate, so those five are each source's top hit however weakly it matched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ypflll
force-pushed
the
fix/raven-default-top-k
branch
from
September 11, 2026 02:16
38361d7 to
68ebb41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-source release (#7) narrowed the
top_kdefault from 5 to 2 across theengine's
SearchConfig, Hermes'sDEFAULTS, and both TypeScript hosts'topK.raven-plugin.tomlis the one place that was left behind, and the line has notbeen touched since the file was created.
Raven's plugin registry (
admit_slice) fills a declared default for every key theoperator leaves out, so a zero-config Raven is the only host injecting five full
SKILL.mdbodies per search where the other four inject two. On the default path(
mode: on_demandwith an emptymodel) no gate is built either, sopool_sizecollapses to
top_kand those five are each source's top hit however weakly itmatched — RRF ranks by position within a source, not by match strength.
Verification
Ran Raven's own
admit_sliceover the plugin'sconfig_schemawith an emptyoperator slice:
top_kresolves to 2 and now equalsSearchConfig().top_k.