Fix Disp variable mapping to use tel_list_matrix before distance sorting #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disp variables (DispTelList_T, Disp_T, DispXoff_T, etc.) were directly copied from column positions without mapping through
tel_list_matrix, causing misalignment when telescope IDs are non-contiguous (e.g., [0, 2, 5]).Changes
_flatten_variable_columnstel_list_matrixmapping to Disp variables as other per-telescope variablesExample
For telescopes [0, 2, 5] with Disp values [10, 20, 30]:
Before: Values incorrectly assigned to telescope IDs [0, 1, 2]
After: Values correctly assigned to telescope IDs [0, 2, 5]
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.