fix: preserve background color for odt#122
Open
DmySyz wants to merge 1 commit into
Open
Conversation
DmySyz
force-pushed
the
fix/background-color-odf
branch
from
281820e to
f3a2319
Compare
Signed-off-by: dsyzov <dmytro.syzov@nextcloud.com>
DmySyz
force-pushed
the
fix/background-color-odf
branch
from
f3a2319 to
641b729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When reading an ODT, the code only checked the default page layout for fo:background-color. If the background was defined on a non-default master page it was silently ignored and nothing got written to the DOCY binary.
With this change it iterates over all master pages until one with fo_background_color_ is found and use that.
Test
Manually tested both end-to-end and with x2t only.
Notes
Assisted-by: ClaudeCode:claude-sonnet-4-6