-
-
Notifications
You must be signed in to change notification settings - Fork 3
GH-118 Add multification-paper module with Paper platform support and examples
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vLuckyyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the Paper platform by adding a new multification-paper module and a corresponding example project. The changes are well-structured, and the new module provides a clean abstraction for Paper servers.
I've identified a few areas for improvement, primarily in the README.md file where some code examples have formatting issues and documentation links appear to be broken. There are also some minor issues in the example code, such as a redundant notification and an opportunity for simplification. In the new multification-paper module, the PaperViewerProvider's all() method implementation seems incorrect as it doesn't include the console.
Overall, this is a great addition to the project. Addressing the feedback will improve the documentation's clarity and the robustness of the example code.
multification-paper/src/com/eternalcode/multification/paper/PaperViewerProvider.java
Show resolved
Hide resolved
examples/paper/src/main/java/com/eternalcode/example/paper/command/FlyCommand.java
Show resolved
Hide resolved
examples/paper/src/main/java/com/eternalcode/example/paper/command/ReloadCommand.java
Show resolved
Hide resolved
examples/paper/src/main/java/com/eternalcode/example/paper/command/timer/TimerManager.java
Show resolved
Hide resolved
examples/paper/src/main/java/com/eternalcode/example/paper/config/MessagesConfig.java
Show resolved
Hide resolved
multification-paper module with Paper platform support and examplesmultification-paper module with Paper platform support and examples
Jakubk15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you touch formatter settings? It looks like there is an extra, unnecessary extra tab character in a lot of places
examples/paper/src/main/java/com/eternalcode/example/paper/command/timer/TimerManager.java
Show resolved
Hide resolved
multification-paper/src/com/eternalcode/multification/paper/PaperViewerProvider.java
Show resolved
Hide resolved
multification-paper/src/com/eternalcode/multification/paper/PaperViewerProvider.java
Outdated
Show resolved
Hide resolved
multification-paper/src/com/eternalcode/multification/paper/PaperViewerProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>
…nd improve formatting.
…fig/MessagesConfig.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.